Re: Review Request 42594: Introduced framework registry operations.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review141537
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 2, 2016, 8:53 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> ---
> 
> (Updated Feb. 2, 2016, 8:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Klaus Ma, Klaus Ma, 
> Qian Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42594: Introduced framework registry operations.

2016-02-02 Thread Yongqiao Wang 


> On Feb. 1, 2016, 9:03 a.m., Jian Qiu wrote:
> > src/master/master.hpp, line 1638
> > 
> >
> > hashset* slaveIDs, bool strict

Those parameters do not be used, so it does not need to name them.


> On Feb. 1, 2016, 9:03 a.m., Jian Qiu wrote:
> > src/master/master.hpp, line 1629
> > 
> >
> > When to use readmit if framwork is not allowed to be updated

According to the original ideas, ReadmitFramework function will be called when 
framework re-register. If the registry do not mutated when framework 
re-register, then we can remove this function.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review117193
---


On Feb. 1, 2016, 7:24 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> ---
> 
> (Updated Feb. 1, 2016, 7:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
> Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42594: Introduced framework registry operations.

2016-02-02 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/
---

(Updated Feb. 2, 2016, 8:53 a.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
Zhang, Jian Qiu, and Vinod Kone.


Changes
---

Addressed Jian's comments.


Bugs: MESOS-1719
https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description
---

Introduced framework registry operations.


Diffs (updated)
-

  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 

Diff: https://reviews.apache.org/r/42594/diff/


Testing
---

Make && Make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 42594: Introduced framework registry operations.

2016-02-02 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review117390
---



Patch looks great!

Reviews applied: [42591, 42594]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 2, 2016, 8:53 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> ---
> 
> (Updated Feb. 2, 2016, 8:53 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
> Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42594: Introduced framework registry operations.

2016-01-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review116340
---



Patch looks great!

Reviews applied: [42591, 42594]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 7:54 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> ---
> 
> (Updated Jan. 26, 2016, 7:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42594: Introduced framework registry operations.

2016-01-25 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/
---

(Updated Jan. 26, 2016, 7:54 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Update the code logic and format.


Bugs: MESOS-1719
https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description
---

Introduced framework registry operations.


Diffs (updated)
-

  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 

Diff: https://reviews.apache.org/r/42594/diff/


Testing
---

Make && Make check successfully!


Thanks,

Yongqiao Wang

Review Request 42594: Introduced framework registry operations.

2016-01-21 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
---

Introduced framework registry operations.


Diffs
-

  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 

Diff: https://reviews.apache.org/r/42594/diff/


Testing
---

Make && Make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 42594: Introduced framework registry operations.

2016-01-21 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/
---

(Updated Jan. 21, 2016, 9:45 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-1719
https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description
---

Introduced framework registry operations.


Diffs
-

  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 

Diff: https://reviews.apache.org/r/42594/diff/


Testing
---

Make && Make check successfully!


Thanks,

Yongqiao Wang