Re: Review Request 42658: Restructured comments in allocator tests for clarity.

2016-02-09 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42658/#review118418
---


Ship it!




Ship It!

- Ben Mahler


On Jan. 28, 2016, 1:11 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42658/
> ---
> 
> (Updated Jan. 28, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Do not describe cluster state in advance to avoid confusion,
> rather right after the state changes.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> f18e6eb10572b0f5b8bbff338384d9406f6ad62b 
> 
> Diff: https://reviews.apache.org/r/42658/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 42658: Restructured comments in allocator tests for clarity.

2016-01-28 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42658/
---

(Updated Jan. 28, 2016, 1:11 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebased.


Repository: mesos


Description
---

Do not describe cluster state in advance to avoid confusion,
rather right after the state changes.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
f18e6eb10572b0f5b8bbff338384d9406f6ad62b 

Diff: https://reviews.apache.org/r/42658/diff/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov



Review Request 42658: Restructured comments in allocator tests for clarity.

2016-01-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42658/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Do not describe cluster state in advance to avoid confusion,
rather right after the state changes.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
b1cb955b7eb1213c7ba4a9c5181545bb49154f06 

Diff: https://reviews.apache.org/r/42658/diff/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov