Re: Review Request 42872: Relaxed the subsystem check for net_cls.

2016-01-27 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42872/#review116672
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (line 75)


You want to update the comments here?



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 82 - 83)


Could you please mentioned that on some systems, net_cls is co-mounted with 
net_prio in the same hierarchy.


- Jie Yu


On Jan. 27, 2016, 10:12 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42872/
> ---
> 
> (Updated Jan. 27, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4530
> https://issues.apache.org/jira/browse/MESOS-4530
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Relaxed the subsystem check for net_cls. The check ensures that only the 
> net_cls and net_prio subsystem can be mounted in the same hierarchy.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> 03a488e0025da2f0a835cdc39379c901a83b78b0 
> 
> Diff: https://reviews.apache.org/r/42872/diff/
> 
> 
> Testing
> ---
> 
> make and make check on Debian 8
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 42872: Relaxed the subsystem check for net_cls.

2016-01-27 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42872/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4530
https://issues.apache.org/jira/browse/MESOS-4530


Repository: mesos


Description
---

Relaxed the subsystem check for net_cls. The check ensures that only the 
net_cls and net_prio subsystem can be mounted in the same hierarchy.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
03a488e0025da2f0a835cdc39379c901a83b78b0 

Diff: https://reviews.apache.org/r/42872/diff/


Testing
---

make and make check on Debian 8


Thanks,

Avinash sridharan