Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Vinod Kone
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > Actually, would it be possible to make the --no-cache=true option > configurable as well? This is useful when running locally to speed up the > build process when I know nothing significant has changed

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Kevin Klues
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! Actually, would it be possible to make the --no-cache=true option configurable as well? This is useful when running locally to speed up the build process when I know nothing significant has changed. - Kevin ---

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116964 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 1:32 a.m., V

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116875 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116865 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 1:32 a.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- (Updated Jan. 29, 2016, 1:32 a.m.) Review request for mesos, Anand Mazumdar, Gr

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:10 a.m.

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116848 --- Ship it! LGTM. Looks like the review bot vaidated that the `Env

Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116847 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command

Review Request 42929: Updated docker_build.sh to make build environment configurable.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Bugs: MES