Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116964 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! Actually, would it be possible to make the --no-cache=true option configurable as well? This is useful when running locally to speed up the build process when I know nothing significant has changed. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
> On Jan. 29, 2016, 1:01 a.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > Actually, would it be possible to make the --no-cache=true option > configurable as well? This is useful when running locally to speed up the > build process when I know nothing significant has changed. I'll let you do that in a separate patch :) - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Bugs: MESOS-4523 https://issues.apache.org/jira/browse/MESOS-4523 Repository: mesos Description --- This sets up the path for creating a new CI job (ENVIRONMENT="MESOS_BENCHMARK=1 GTEST_FILTER='*BENCHMARK*'" that runs benchmark tests. Diffs - support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 Diff: https://reviews.apache.org/r/42929/diff/ Testing --- Tested this via a custom CI job on ASF CI. Note that the benchmark tests need to be reconfigured to not take a long time. Currently they get aborted because they ran for > 5 hours. Thanks, Vinod Kone
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116847 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh Error: .. + : ubuntu:14.04 + : gcc + : --verbose ./support/docker_build.sh: line 12: ENVIRONMENT: Environment variable 'ENVIRONMENT' must be set (e.g., ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1') Full log: https://builds.apache.org/job/mesos-reviewbot/11104/console - Mesos ReviewBot On Jan. 29, 2016, 12:10 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 12:10 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > This sets up the path for creating a new CI job > (ENVIRONMENT="MESOS_BENCHMARK=1 GTEST_FILTER='*BENCHMARK*'" that runs > benchmark tests. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116848 --- Ship it! LGTM. Looks like the review bot vaidated that the `Environment` stuff works already ;-) - Anand Mazumdar On Jan. 29, 2016, 12:10 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 12:10 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > This sets up the path for creating a new CI job > (ENVIRONMENT="MESOS_BENCHMARK=1 GTEST_FILTER='*BENCHMARK*'" that runs > benchmark tests. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116854 --- Ship it! Ship It! - Kevin Klues On Jan. 29, 2016, 12:10 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 12:10 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > This sets up the path for creating a new CI job > (ENVIRONMENT="MESOS_BENCHMARK=1 GTEST_FILTER='*BENCHMARK*'" that runs > benchmark tests. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/ --- (Updated Jan. 29, 2016, 1:32 a.m.) Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. Changes --- Updated verify_reviews.py too. Thanks ReviewBot! Bugs: MESOS-4523 https://issues.apache.org/jira/browse/MESOS-4523 Repository: mesos Description (updated) --- Updated docker_build.sh to make build environment configurable. Diffs (updated) - support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 Diff: https://reviews.apache.org/r/42929/diff/ Testing --- Tested this via a custom CI job on ASF CI. Note that the benchmark tests need to be reconfigured to not take a long time. Currently they get aborted because they ran for > 5 hours. Thanks, Vinod Kone
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116865 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42929: Updated docker_build.sh to make build environment configurable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42929/#review116875 --- Bad patch! Reviews applied: [42927, 42928, 42929] Failed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh Error: .. + : ubuntu:14.04 + : gcc + : --verbose ./support/docker_build.sh: line 12: ENVIRONMENT: Environment variable 'ENVIRONMENT' must be set (e.g., ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1') Full log: https://builds.apache.org/job/mesos-reviewbot/11106/console - Mesos ReviewBot On Jan. 29, 2016, 1:32 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42929/ > --- > > (Updated Jan. 29, 2016, 1:32 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Kevin Klues. > > > Bugs: MESOS-4523 > https://issues.apache.org/jira/browse/MESOS-4523 > > > Repository: mesos > > > Description > --- > > Updated docker_build.sh to make build environment configurable. > > > Diffs > - > > support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 > support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 > > Diff: https://reviews.apache.org/r/42929/diff/ > > > Testing > --- > > Tested this via a custom CI job on ASF CI. > > Note that the benchmark tests need to be reconfigured to not take a long > time. Currently they get aborted because they ran for > 5 hours. > > > Thanks, > > Vinod Kone > >
