Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 9:31 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
> On Jan. 29, 2016, 7:52 p.m., Vinod Kone wrote: > > My only question is about line wrapping. Doesn't seem to be consistent > > across the file. Is the plan to wrap them all at 80 chars? The current wrapping is based on the help strings found in the various `flags.cpp` files. Backticks are con

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 8:18 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 8:13 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 8:02 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/#review116994 --- Fix it, then Ship it! My only question is about line wrapping.

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 7:16 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
> On Jan. 29, 2016, 5:56 p.m., Joseph Wu wrote: > > docs/configuration.md, lines 350-352 > > > > > > Does this render correctly for you? Adjacent `` blocks are > > rendered inline. Good catch, thanks Joseph! - G

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/#review116967 --- A couple of fixes you can make to the help strings and then auto-g

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 5:41 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- (Updated Jan. 29, 2016, 5:25 a.m.) Review request for mesos and Vinod Kone. B

Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42939/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4298 https://issues.ap