Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 9, 2016, 9:03 p.m., Ezra Silvera wrote: > > src/docker/docker.cpp, lines 304-305 > > > > > > Please note that a container can be attached to more then one network! > > In that case HostConfig.NetworkMode

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122802 --- src/docker/docker.cpp (lines 304 - 305)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 9, 2016, 8:48 p.m., Ezra Silvera wrote: > > Please note that a container can be attached to more then one network! In > > that case HostConfig.NetworkMode will contain the first NW the container > > was attached two. The desired IP, however, might be the one on a different > > NW

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122796 --- Please note that a container can be attached to more then one

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. Hi Timothy, I've been stalling this for https://reviews.apache.org/r/42516, as that patch

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review122314 --- Are you still be able to work on this? We like to get this

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review119264 --- src/docker/docker.cpp (line 310)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

On 二月 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks > > Joerg Schad wrote: > Oh btw regarding the commit message: > We usually have commit messages stating what changed, so in your case it > could be something along the lines of 'Added support for new docker network > setting.' >

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks > > Joerg Schad wrote: > Oh btw regarding the commit message: > We usually have commit messages stating what changed, so in your case it > could be something along the lines of 'Added support for new docker network > setting.'

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks > > Joerg Schad wrote: > Oh btw regarding the commit message: > We usually have commit messages stating what changed, so in your case it > could be something along the lines of 'Added support for new docker network > setting.'

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 2:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review118436 --- Thanks for taking this on! Some small remarks below. Overall

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks Oh btw regarding the commit message: We usually have commit messages stating what changed, so in your case it could be something along the lines of 'Added support for new docker network setting.' - Joerg

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On 二月 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e. prior

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 4, 2016, 9:27 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117936 --- Bad patch! Reviews applied: [43093] Failed command:

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117602 --- src/docker/docker.cpp (line 326)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117600 --- src/docker/docker.cpp (line 316)

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117658 --- Bad patch! Reviews applied: [43093] Failed command:

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 3, 2016, 8:47 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 304 > > > > > > According > > https://docs.docker.com/engine/reference/api/docker_remote_api/ Seems this > > would have problem

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 3, 2016, 7:04 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 3, 2016, 8:58 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 326 > > > > > > If we could add some assert code about ip value in `TEST_F(DockerTest, > > ROOT_DOCKER_interface)` would make this

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 2, 2016, 6:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117461 --- Bad patch! Reviews applied: [43093] Failed command:

Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ --- (Updated Feb. 2, 2016, 5:06 p.m.) Review request for mesos and Kapil Arya.