Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-09 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/
---

(Updated Feb. 9, 2016, 10:53 p.m.)


Review request for mesos, Greg Mann and Jie Yu.


Changes
---

Also change endpoint help text.


Bugs: MESOS-4421
https://issues.apache.org/jira/browse/MESOS-4421


Repository: mesos


Description
---

Corrected mistakes in docs for volume/reservation HTTP endpoints.


Diffs (updated)
-

  docs/endpoints/master/create-volumes.md 
f167452377787920414e8e1ec7712556dae29a65 
  docs/endpoints/master/destroy-volumes.md 
a9a12adc017d61f77ddacc26c84daa37657c2355 
  docs/endpoints/master/reserve.md 6d4dee457b79ffd6db1520ab49c5c3331290510e 
  docs/endpoints/master/unreserve.md 81c72d3253141586d6dbe278a07ce1ff179488c6 
  docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
  src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 

Diff: https://reviews.apache.org/r/43118/diff/


Testing
---

Previewed in site-docker.


Thanks,

Neil Conway



Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-09 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/#review118521
---



Patch looks great!

Reviews applied: [43118]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 10:53 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43118/
> ---
> 
> (Updated Feb. 9, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-4421
> https://issues.apache.org/jira/browse/MESOS-4421
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected mistakes in docs for volume/reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> f167452377787920414e8e1ec7712556dae29a65 
>   docs/endpoints/master/destroy-volumes.md 
> a9a12adc017d61f77ddacc26c84daa37657c2355 
>   docs/endpoints/master/reserve.md 6d4dee457b79ffd6db1520ab49c5c3331290510e 
>   docs/endpoints/master/unreserve.md 81c72d3253141586d6dbe278a07ce1ff179488c6 
>   docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
>   src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 
> 
> Diff: https://reviews.apache.org/r/43118/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-04 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/#review117817
---


Ship it!




Ship It!

- Guangya Liu


On Feb. 3, 2016, 12:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43118/
> ---
> 
> (Updated Feb. 3, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-4421
> https://issues.apache.org/jira/browse/MESOS-4421
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected mistakes in docs for volume/reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43118/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-02 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4421
https://issues.apache.org/jira/browse/MESOS-4421


Repository: mesos


Description
---

Corrected mistakes in docs for volume/reservation HTTP endpoints.


Diffs
-

  docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/43118/diff/


Testing
---

Previewed in site-docker.


Thanks,

Neil Conway



Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-02 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/
---

(Updated Feb. 3, 2016, 12:39 a.m.)


Review request for mesos, Greg Mann and Jie Yu.


Changes
---

Fix per Greg's review.


Bugs: MESOS-4421
https://issues.apache.org/jira/browse/MESOS-4421


Repository: mesos


Description
---

Corrected mistakes in docs for volume/reservation HTTP endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/43118/diff/


Testing
---

Previewed in site-docker.


Thanks,

Neil Conway



Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/#review117571
---



Patch looks great!

Reviews applied: [43118]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 12:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43118/
> ---
> 
> (Updated Feb. 3, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-4421
> https://issues.apache.org/jira/browse/MESOS-4421
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected mistakes in docs for volume/reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43118/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43118/#review117524
---



Patch looks great!

Reviews applied: [43118]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 2, 2016, 10:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43118/
> ---
> 
> (Updated Feb. 2, 2016, 10:44 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-4421
> https://issues.apache.org/jira/browse/MESOS-4421
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Corrected mistakes in docs for volume/reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 9657c3f75dcc17dfd4d6391b35da3dbc0a6c547d 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43118/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>