Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

2016-02-03 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43161/
---

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582


Repository: mesos


Description
---

See [r43160](https://reviews.apache.org/r/43160) for details. This patch adds a 
`picojson-1.3.0.patch` to restrict `picojson::parse` from allowing duplicate 
keys.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
42c95a970b13ef4d72665d0b87bac87722f6decd 
  3rdparty/libprocess/3rdparty/picojson-1.3.0.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/43161/diff/


Testing
---

See [r43160](https://reviews.apache.org/r/43160).


Thanks,

Michael Park



Re: Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

2016-02-03 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43161/#review117733
---



Patch looks great!

Reviews applied: [43159, 43160, 43161]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 11:10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43161/
> ---
> 
> (Updated Feb. 3, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4582
> https://issues.apache.org/jira/browse/MESOS-4582
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [r43160](https://reviews.apache.org/r/43160) for details. This patch adds 
> a `picojson-1.3.0.patch` to restrict `picojson::parse` from allowing 
> duplicate keys.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 42c95a970b13ef4d72665d0b87bac87722f6decd 
>   3rdparty/libprocess/3rdparty/picojson-1.3.0.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43161/diff/
> 
> 
> Testing
> ---
> 
> See [r43160](https://reviews.apache.org/r/43160).
> 
> 
> Thanks,
> 
> Michael Park
> 
>