Re: Review Request 43166: Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.

2016-02-04 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43166/#review117897
---


Ship it!




You forgot to modify port mapping tests. I'll fix it for you.

- Jie Yu


On Feb. 4, 2016, 12:35 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43166/
> ---
> 
> (Updated Feb. 4, 2016, 12:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
>   src/slave/containerizer/mesos/launch.hpp 
> 722031956494647c81436a95400d939eec4466de 
>   src/slave/containerizer/mesos/launch.cpp 
> 0cfdc0ca1a7e8c6107f8ea46e7a4c6e52811d7ac 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
> 
> Diff: https://reviews.apache.org/r/43166/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Review Request 43166: Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.

2016-02-03 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43166/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/launch.hpp 
722031956494647c81436a95400d939eec4466de 
  src/slave/containerizer/mesos/launch.cpp 
0cfdc0ca1a7e8c6107f8ea46e7a4c6e52811d7ac 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 

Diff: https://reviews.apache.org/r/43166/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song