Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118034 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 10:14 a.m.,

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Shuai Lin
> On Feb. 5, 2016, 5:18 p.m., Jie Yu wrote: > > Ship It! Jie Yu, Can you shepherd/commit it? - Shuai --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118034

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Shuai Lin
> On Feb. 5, 2016, 5:18 p.m., Jie Yu wrote: > > Ship It! > > Shuai Lin wrote: > Jie Yu, Can you shepherd/commit it? oops, just saw it already commited, thanks! - Shuai --- This is an automatically generated e-mail. To reply,

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Shuai Lin
> On Feb. 5, 2016, 8:47 a.m., Guangya Liu wrote: > > But the unit test does passed > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_tests.cpp#L578-L579 > > even without your fix, can you please clarify why the unit test passed for > > validating

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 5, 2016, 10:14 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117992 --- But the unit test does passed

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 5, 2016, 9:50 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117999 --- src/tests/containerizer/docker_tests.cpp (line 507)

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118007 --- Patch looks great! Reviews applied: [43193] Passed command:

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review118004 --- Ship it! Thanks for the update - Guangya Liu On 二月 5, 2016,

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 4, 2016, 5:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4587

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117838 --- Ship it! Ship It! - haosdent huang On Feb. 4, 2016, 5:07

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/ --- (Updated Feb. 4, 2016, 6:07 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43193: Fixed parsing docker image env vars.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43193/#review117849 --- Patch looks great! Reviews applied: [43193] Passed command: