Re: Review Request 43284: Wait for perf statistics processes exit.

2016-03-31 Thread haosdent huang
> On Feb. 8, 2016, 10:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-14 Thread haosdent huang
> On Feb. 8, 2016, 10:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated Feb. 14, 2016, 7:59 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/#review118312 --- src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
> On Feb. 8, 2016, 2:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated Feb. 7, 2016, 8:12 a.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated Feb. 7, 2016, 8:14 a.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/#review118161 --- Patch looks great! Reviews applied: [43283, 43284] Passed

Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- Review request for mesos and Jan Schlicht. Bugs: MESOS-4039