Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread haosdent huang
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 160 > > > > > > Why we not use `const` instead of `constexpr` here? > > Joris Van Remoortere wrote:

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread Joris Van Remoortere
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 160 > > > > > > Why we not use `const` instead of `constexpr` here? Because a parameter to a

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/#review118215 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 160)

Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

2016-02-07 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos