Re: Review Request 43434: Constrain one of Option's constructors to 'constructible' types.

2016-02-11 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43434/#review118835
---


Ship it!




Ship It!

- Michael Park


On Feb. 10, 2016, 11:35 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43434/
> ---
> 
> (Updated Feb. 10, 2016, 11:35 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4633
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> 6b66bce76838046d7c955188ab9ac05e12756a83 
> 
> Diff: https://reviews.apache.org/r/43434/diff/
> 
> 
> Testing
> ---
> 
> Note: All credit for this patch, including the below example, goes to MPark :)
> 
> Lets us compile something like this:
> ```
> struct Foo {};
> 
> void F(const std::string&) {}
> void F(const Option&) {}
> 
> TEST(OptionTest, ConditionalConstruct)
> {
>   F("hello");
> }
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 43434: Constrain one of Option's constructors to 'constructible' types.

2016-02-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43434/
---

Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Michael Park.


Bugs: MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4633


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
6b66bce76838046d7c955188ab9ac05e12756a83 

Diff: https://reviews.apache.org/r/43434/diff/


Testing
---

Note: All credit for this patch, including the below example, goes to MPark :)

Lets us compile something like this:
```
struct Foo {};

void F(const std::string&) {}
void F(const Option&) {}

TEST(OptionTest, ConditionalConstruct)
{
  F("hello");
}
```


Thanks,

Joseph Wu