----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43440/ -----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs: MESOS-4633 https://issues.apache.org/jira/browse/MESOS-4633 Repository: mesos Description ------- Makes the following changes: * All objects passed to `StartSlave` are transformed into `shared_ptr`. * References to the above objects are updated to reflect the different type. * Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency. * Removes manual `delete`s inside tests. * Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`). * Removes extraneous spaces in `Try<PID<Slave> >` in touched lines. Diffs ----- src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8 src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8 src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 Diff: https://reviews.apache.org/r/43440/diff/ Testing ------- Tests are run at the very, very end of this review chain. Thanks, Joseph Wu