Re: Review Request 43444: Update disk tests to pass shared_ptrs to 'StartSlave'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43444/ --- (Updated Feb. 11, 2016, 11:34 a.m.) Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Changes --- Remove ownership of `containerizer` from FetcherCache tests. Bugs: MESOS-4633 https://issues.apache.org/jira/browse/MESOS-4633 Repository: mesos Description --- Makes the following changes: * All objects passed to `StartSlave` are transformed into `shared_ptr`. * References to the above objects are updated to reflect the different type. * Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency. * Removes manual `delete`s inside tests. * Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`). * Removes extraneous spaces in `Try` in touched lines. Diffs (updated) - src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/persistent_volume_tests.cpp e169e1b141a38dc389eefd42c11a078c413123d5 Diff: https://reviews.apache.org/r/43444/diff/ Testing --- Tests are run at the very, very end of this review chain. Thanks, Joseph Wu
Review Request 43444: Update disk tests to pass shared_ptrs to 'StartSlave'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43444/ --- Review request for mesos, Bernd Mathiske and Artem Harutyunyan. Bugs: MESOS-4633 https://issues.apache.org/jira/browse/MESOS-4633 Repository: mesos Description --- Makes the following changes: * All objects passed to `StartSlave` are transformed into `shared_ptr`. * References to the above objects are updated to reflect the different type. * Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency. * Removes manual `delete`s inside tests. * Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`). * Removes extraneous spaces in `Try` in touched lines. Diffs - src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/persistent_volume_tests.cpp e169e1b141a38dc389eefd42c11a078c413123d5 Diff: https://reviews.apache.org/r/43444/diff/ Testing --- Tests are run at the very, very end of this review chain. Thanks, Joseph Wu