Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Guangya Liu
> On 二月 12, 2016, 6:13 p.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp, line 219 > > > > > > Whitespace error. I was following the style of https://github.com/apache/mesos/bl

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review119051 --- 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp (line

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Guangya Liu
> On 二月 12, 2016, 9:35 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, lines 136-171 > > > > > > How about the following to simplify the logic and make it consistent > > wit

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118989 --- Ship it! I'll go ahead and make the fix for the above issue, th

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118988 --- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp (lin

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-11 Thread Guangya Liu
> On 二月 11, 2016, 6:14 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp, line 230 > > > > > > Align the indent here would be better. Done. - Guangya

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/ --- (Updated 二月 11, 2016, 8:32 a.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118818 --- 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp (line

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118817 --- Ship it! Ship It! - haosdent huang On Feb. 11, 2016, 5:37 a.

Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

2016-02-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3833 https://issues.ap