Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-29 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review121210
---




docs/persistent-volume.md (lines 82 - 106)


Turns out this part actually needs 8 spaces since it's a body of a list. 
Fixed and committed.


- Michael Park


On Feb. 22, 2016, 5:18 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 22, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
> Docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-28 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review121207
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 5:18 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 22, 2016, 5:18 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
> Docker website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-22 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/
---

(Updated Feb. 22, 2016, 5:18 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
---

Consistent markdown code style in persistent-volumes.md.


Diffs (updated)
-

  docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 

Diff: https://reviews.apache.org/r/43634/diff/


Testing (updated)
---

Viewed via gist (https://gist.github.com/joerg84/74e065fbcfd130d90cf7) and 
Docker website container.


Thanks,

Joerg Schad

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-22 Thread Joerg Schad 


> On Feb. 22, 2016, 8:16 a.m., Michael Park wrote:
> > docs/persistent-volume.md, line 56
> > 
> >
> > Do you know if we actually have a good reason for the 8 space indent 
> > here as opposed to 4? I noticed that `docs/reservation.md` has 8 spaces as 
> > well, but I don't remember why I did that nor where I got it from :(

You are right 4 is enough and consistent with the markdown styleguide but not 
with other files (reservation, quota).
I updated this file and follow up by making the other files consistent.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review120127
---


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-22 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review120127
---




docs/persistent-volume.md (line 55)


Do you know if we actually have a good reason for the 8 space indent here 
as opposed to 4? I noticed that `docs/reservation.md` has 8 spaces as well, but 
I don't remember why I did that nor where I got it from :(


- Michael Park


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review119405
---



Patch looks great!

Reviews applied: [43634]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

2016-02-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43634/#review119379
---


Ship it!




Ship It!

- Neil Conway


On Feb. 16, 2016, 11:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43634/
> ---
> 
> (Updated Feb. 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Consistent markdown code style in persistent-volumes.md.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 728854076595a0908a17d85482a7031acfbb09a0 
> 
> Diff: https://reviews.apache.org/r/43634/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>