Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-28 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review121208
---


Ship it!




Ship It!

- Michael Park


On Feb. 22, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 22, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-22 Thread Joerg Schad


> On Feb. 22, 2016, 8:43 a.m., Michael Park wrote:
> > Upon looking through the pattern, it seems like the evolution of this has 
> > been:
> > 
> > ```
> > In order to upgrade a running cluster:
> > 
> > * ...
> > * ...
> > ```
> > 
> > then came some `NOTE`s:
> > 
> > ```
> > __NOTE__: ...
> > 
> > __NOTE__: ...
> > 
> > In order to upgrade a running cluster:
> > 
> > * ...
> > * ...
> > ```
> > 
> > Now that we're changing __NOTE__ to bullets, I think we can
> > 
> >   1. Keep the "In order to upgrade a running cluster" at the same level as 
> > the bullets
> >   2. Replace the bullets under "In order to upgrade a running cluster" to 
> > numbers.
> > 
> > __NOTE__: I noticed that the "upgrading a running cluster" section is 
> > missing for 0.25 -> 0.26
> >   as well as 0.26 -> 0.27, so I created JIRAs to track those as 
> > well.
> >   [MESOS-4734](https://issues.apache.org/jira/browse/MESOS-4734)

Adapted to your proposed format.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review120129
---


On Feb. 22, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 22, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-22 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/
---

(Updated Feb. 22, 2016, 6 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
---

Adressed comment.


Repository: mesos


Description
---

Made bullet point structure consistent in upgrades.md.


Diffs (updated)
-

  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 

Diff: https://reviews.apache.org/r/43792/diff/


Testing
---

Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via 
docker website renderer.


Thanks,

Joerg Schad



Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-22 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review120129
---



Upon looking through the pattern, it seems like the evolution of this has been:

```
In order to upgrade a running cluster:

* ...
* ...
```

then came some `NOTE`s:

```
__NOTE__: ...

__NOTE__: ...

In order to upgrade a running cluster:

* ...
* ...
```

Now that we're changing __NOTE__ to bullets, I think we can

  1. Keep the "In order to upgrade a running cluster" at the same level as the 
bullets
  2. Replace the bullets under "In order to upgrade a running cluster" to 
numbers.

__NOTE__: I noticed that the "upgrading a running cluster" section is missing 
for 0.25 -> 0.26
  as well as 0.26 -> 0.27, so I created JIRAs to track those as well.
  [MESOS-4734](https://issues.apache.org/jira/browse/MESOS-4734)

- Michael Park


On Feb. 20, 2016, 12:22 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 20, 2016, 12:22 a.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-19 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/
---

(Updated Feb. 20, 2016, 12:22 a.m.)


Review request for mesos, Michael Park and Neil Conway.


Summary (updated)
-

Made bullet point structure consistent in upgrades.md.


Repository: mesos


Description (updated)
---

Made bullet point structure consistent in upgrades.md.


Diffs
-

  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 

Diff: https://reviews.apache.org/r/43792/diff/


Testing
---

Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via 
docker website renderer.


Thanks,

Joerg Schad



Re: Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-19 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/#review119995
---


Ship it!




Ship It!

- Neil Conway


On Feb. 20, 2016, 12:03 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43792/
> ---
> 
> (Updated Feb. 20, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made bullet point structure consistent in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
> 
> Diff: https://reviews.apache.org/r/43792/diff/
> 
> 
> Testing
> ---
> 
> Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and 
> via docker website renderer.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Review Request 43792: Made bullet point structure consistent in upgrades.md.

2016-02-19 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43792/
---

Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
---

Made bullet point structure consistent in upgrades.md.


Diffs
-

  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 

Diff: https://reviews.apache.org/r/43792/diff/


Testing
---

Viewed in github (https://gist.github.com/joerg84/3cd9077f3446a6c6bb50) and via 
docker website renderer.


Thanks,

Joerg Schad