Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

2016-02-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review120119
---



Patch looks great!

Reviews applied: [43816, 43817]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 2:11 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> ---
> 
> (Updated Feb. 22, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These provided functionality that is now implemented via jsonify; no more
> call-sites of the old functions remain.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
> 
> Diff: https://reviews.apache.org/r/43817/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also updated a few comments to not refer to `summarize`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

2016-02-21 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

These provided functionality that is now implemented via jsonify; no more
call-sites of the old functions remain.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43817/diff/


Testing
---

make check


Thanks,

Neil Conway



Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

2016-02-21 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

(Updated Feb. 22, 2016, 2:11 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

These provided functionality that is now implemented via jsonify; no more
call-sites of the old functions remain.


Diffs
-

  src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 

Diff: https://reviews.apache.org/r/43817/diff/


Testing (updated)
---

make check

Also updated a few comments to not refer to `summarize`.


Thanks,

Neil Conway