Re: Review Request 43864: Fix typo of roles doc.

2016-02-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120531 --- Ship it! Ship It! - Neil Conway On Feb. 24, 2016, 3:34 a.m.,

Re: Review Request 43864: Fix typo of roles doc.

2016-02-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120480 --- Patch looks great! Reviews applied: [43864] Passed command: expo

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Klaus Ma
> On Feb. 24, 2016, 2:06 a.m., Neil Conway wrote: > > The right place to make this fix is in `src/master/http.cpp`, and then > > rerun `support/generate-endpoint-help.py`. Seems like > > `Master::Http::ROLES_HELP` is missing commas in `DESCRIPTION`. You're right, we missed commas in `Master::H

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/ --- (Updated Feb. 24, 2016, 11:34 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120347 --- The right place to make this fix is in `src/master/http.cpp`, and

Re: Review Request 43864: Fix typo of roles doc.

2016-02-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/#review120287 --- Patch looks great! Reviews applied: [43864] Passed command: expo

Review Request 43864: Fix typo of roles doc.

2016-02-22 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43864/ --- Review request for mesos and Neil Conway. Repository: mesos Description -