Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121602
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 7:26 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated March 2, 2016, 7:26 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-03-01 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/
---

(Updated March 2, 2016, 7:26 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Changes
---

darroyo's commit breaks this one; let's fix that.


Repository: mesos


Description
---

CMake: Added files to be built as part of libmesos.


Diffs (updated)
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 

Diff: https://reviews.apache.org/r/43906/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-27 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121099
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-27 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121098
---




src/CMakeLists.txt (line 376)


Please lift the values used by the build.cpp and passed as BUILD* defines 
into their ows CMAKE macros to get dynamic values into a subsequential commit.


- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-26 Thread Alex Naparu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review120968
---


Ship it!




Ship It!

- Alex Naparu


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-25 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake: Added files to be built as part of libmesos.


Diffs
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 

Diff: https://reviews.apache.org/r/43906/diff/


Testing
---


Thanks,

Alex Clemmer