Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-03-01 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/
---

(Updated March 2, 2016, 3:55 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[1/2] Fix error reporting bug in `os::rmdir`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 

Diff: https://reviews.apache.org/r/43907/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-03-01 Thread Alex Clemmer 


> On March 1, 2016, 10:56 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, lines 
> > 40-43
> > 
> >
> > How is this different from `fts_open` returning null with errno set to 
> > `ENOENT` below?

Good question. I've added a comment explaining -- `fts_open` won't actually 
return `NULL` on invalid paths, so if you try to `rmdir` an invalid path, you 
don't get an error.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121530
---


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121530
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp (lines 40 - 
43)


How is this different from `fts_open` returning null with errno set to 
`ENOENT` below?


- Joris Van Remoortere


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-27 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121100
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-26 Thread Alex Naparu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review120964
---


Ship it!




Ship It!

- Alex Naparu


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-25 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[1/2] Fix error reporting bug in `os::rmdir`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 

Diff: https://reviews.apache.org/r/43907/diff/


Testing
---


Thanks,

Alex Clemmer