Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated March 11, 2016, 10:11 p.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- Enhanced a test case for the `/state` agent endpoint. Diffs (updated) - src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/43910/diff/ Testing --- make check Note that we don't currently check the conversion of `TaskInfo` -> JSON, which is used for `queuedTasks`. Would be nice to improve the test case so that the slave has a queued task, although this will probably require some `DROP_MESSAGE` trickery... Thanks, Neil Conway
Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/#review122957 --- Ship it! Ship It! - Michael Park On Feb. 29, 2016, 6:55 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43910/ > --- > > (Updated Feb. 29, 2016, 6:55 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > Enhanced a test case for the `/state` agent endpoint. > > > Diffs > - > > src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 > > Diff: https://reviews.apache.org/r/43910/diff/ > > > Testing > --- > > make check > > Note that we don't currently check the conversion of `TaskInfo` -> JSON, > which is used for `queuedTasks`. Would be nice to improve the test case so > that the slave has a queued task, although this will probably require some > `DROP_MESSAGE` trickery... > > > Thanks, > > Neil Conway > >
Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 29, 2016, 6:55 a.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- Enhanced a test case for the `/state` agent endpoint. Diffs (updated) - src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 Diff: https://reviews.apache.org/r/43910/diff/ Testing --- make check Note that we don't currently check the conversion of `TaskInfo` -> JSON, which is used for `queuedTasks`. Would be nice to improve the test case so that the slave has a queued task, although this will probably require some `DROP_MESSAGE` trickery... Thanks, Neil Conway
Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 28, 2016, 12:21 a.m.) Review request for mesos and Michael Park. Repository: mesos Description --- Enhanced a test case for the `/state` agent endpoint. Diffs - src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 Diff: https://reviews.apache.org/r/43910/diff/ Testing (updated) --- make check Note that we don't currently check the conversion of `TaskInfo` -> JSON, which is used for `queuedTasks`. Would be nice to improve the test case so that the slave has a queued task, although this will probably require some `DROP_MESSAGE` trickery... Thanks, Neil Conway
Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- Enhanced a test case for the `/state` agent endpoint. Diffs (updated) - src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 Diff: https://reviews.apache.org/r/43910/diff/ Testing --- make check Thanks, Neil Conway
Review Request 43910: Enhanced a test case for the `/state` agent endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- Review request for mesos and Michael Park. Repository: mesos Description --- Enhanced a test case for the `/state` agent endpoint. Diffs - src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a Diff: https://reviews.apache.org/r/43910/diff/ Testing --- make check Thanks, Neil Conway
