Re: Review Request 43935: Allow setting role in mesos-execute.

2016-04-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review128009 --- Ship it! Ship It! - Michael Park On April 9, 2016, 7:14

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review127979 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-04-09 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 四月 9, 2016, 7:14 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review126202 --- Fix it, then Ship it! src/cli/execute.cpp (line 483)

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125698 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-28 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 28, 2016, 1:11 p.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-27 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 28, 2016, 1:30 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125545 --- src/cli/execute.cpp (line 129)

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125449 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-25 Thread Greg Mann
> On March 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > > > > > s/sepcified/specified/ > > Jian Qiu wrote: > Sorry for the typo... please review again. No worries :-) The patch

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Jian Qiu
> On 三月 24, 2016, 7:57 p.m., Greg Mann wrote: > > src/cli/execute.cpp, line 215 > > > > > > s/sepcified/specified/ Sorry for the typo... please review again. - Jian

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 25, 2016, 1:54 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review125329 --- Fix it, then Ship it! src/cli/execute.cpp (line 214)

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124758 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-21 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 22, 2016, 2:57 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124613 --- Looks great! A couple small comments below. src/cli/execute.cpp

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124007 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-19 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 17, 2016, 1:39 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-15 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 15, 2016, 2:07 p.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-15 Thread Jian Qiu
> On 三月 15, 2016, 12:26 p.m., Guangya Liu wrote: > > src/cli/execute.cpp, lines 216-222 > > > > > > Do you mean that here the framework task can only use reserved > > resources if the framework has a role? What

Re: Review Request 43935: Allow setting role in mesos-execute.

2016-03-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review123644 --- src/cli/execute.cpp (line 129)

Review Request 43935: Allow setting role in mesos-execute.

2016-03-15 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- Review request for mesos, Greg Mann, Shuai Lin, and Michael Park. Bugs: