Re: Review Request 43937: Added missing `json` declaration for `ExecutorInfo`.

2016-02-24 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43937/#review120665
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 24, 2016, 9:06 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43937/
> ---
> 
> (Updated Feb. 24, 2016, 9:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4754
> https://issues.apache.org/jira/browse/MESOS-4754
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See JIRA ticket.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp f88590f0a31f5d267e0716dda52a8126cd1ba5cd 
> 
> Diff: https://reviews.apache.org/r/43937/diff/
> 
> 
> Testing
> ---
> 
> Manaully launched master, agent, `long-lived-framework` and queried the 
> `/state` endpoint.
> 
> 
> ## 0.26.0
> 
> ```
> "executors": [
> {
> "command": {
> "argv": [],
> "uris": [],
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": "default",
> "framework_id": 
> "0ea528a9-64ba-417f-98ea-9c4b8d418db6-",
> "name": "Long Lived Executor (C++)",
> "resources": {
> "cpus": 0,
> "disk": 0,
> "mem": 0
> },
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
> }
> ],```
> 
> ## 0.27.1
> 
> ```
> "executors": [
> {
> "command": {
> "shell": true,
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": {
> "value": "default"
> },
> "framework_id": {
> "value": "368a5a49-480b-41f6-a13b-24a69c92a72e-"
> },
> "name": "Long Lived Executor (C++)",
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0",
> "source": "cpp_long_lived_framework"
> }
> ],
> ```
> 
> ## with this patch
> 
> ```
> "executors": [
> {
> "command": {
> "argv": [],
> "uris": [],
> "value": 
> "/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
> },
> "executor_id": "default",
> "framework_id": 
> "c660529a-c5ce-4aa4-8a67-67657b564a4e-",
> "name": "Long Lived Executor (C++)",
> "resources": {
> "cpus": 0.0,
> "disk": 0.0,
> "mem": 0.0
> },
> "slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
> }
> ],
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>



Review Request 43937: Added missing `json` declaration for `ExecutorInfo`.

2016-02-24 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43937/
---

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4754
https://issues.apache.org/jira/browse/MESOS-4754


Repository: mesos


Description
---

See JIRA ticket.


Diffs
-

  src/common/http.hpp f88590f0a31f5d267e0716dda52a8126cd1ba5cd 

Diff: https://reviews.apache.org/r/43937/diff/


Testing
---

Manaully launched master, agent, `long-lived-framework` and queried the 
`/state` endpoint.


## 0.26.0

```
"executors": [
{
"command": {
"argv": [],
"uris": [],
"value": 
"/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
},
"executor_id": "default",
"framework_id": "0ea528a9-64ba-417f-98ea-9c4b8d418db6-",
"name": "Long Lived Executor (C++)",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
}
],```

## 0.27.1

```
"executors": [
{
"command": {
"shell": true,
"value": 
"/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
},
"executor_id": {
"value": "default"
},
"framework_id": {
"value": "368a5a49-480b-41f6-a13b-24a69c92a72e-"
},
"name": "Long Lived Executor (C++)",
"slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0",
"source": "cpp_long_lived_framework"
}
],
```

## with this patch

```
"executors": [
{
"command": {
"argv": [],
"uris": [],
"value": 
"/Users/mpark/Projects/mesos/build/opt/src/long-lived-executor"
},
"executor_id": "default",
"framework_id": "c660529a-c5ce-4aa4-8a67-67657b564a4e-",
"name": "Long Lived Executor (C++)",
"resources": {
"cpus": 0.0,
"disk": 0.0,
"mem": 0.0
},
"slave_id": "8a513678-03a1-4cb5-9279-c3c0c591f1d8-S0"
}
],
```


Thanks,

Michael Park