Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-03-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review122442 --- Fix it, then Ship it! include/mesos/mesos.proto (lines 1585 -

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-03-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121444 --- Ship it! Ship It! - Gilbert Song On Feb. 29, 2016, 11:28

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121419 --- Patch looks great! Reviews applied: [44004] Passed command:

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- (Updated March 1, 2016, 3:28 p.m.) Review request for mesos, Avinash

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Avinash sridharan
> On Feb. 29, 2016, 8:19 p.m., Avinash sridharan wrote: > > include/mesos/mesos.proto, line 1585 > > > > > > s/, E.g., for MesosContainerizer/. For ,e.g., in case of the > > `MesosContainerizer`/ Actually, made a

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Avinash sridharan
> On Feb. 29, 2016, 8:16 p.m., Avinash sridharan wrote: > > Ship It! Fix it, then ship it !! - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121313

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121315 --- include/mesos/mesos.proto (line 1585)

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121313 --- Ship it! Ship It! - Avinash sridharan On Feb. 29, 2016,

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121247 --- Patch looks great! Reviews applied: [44004] Passed command:

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- (Updated Feb. 29, 2016, 10:04 p.m.) Review request for mesos, Avinash

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Qian Zhang
> On Feb. 26, 2016, 9 a.m., Avinash sridharan wrote: > > include/mesos/mesos.proto, line 1577 > > > > > > In order to expose this field in state.json, I think you need to add > > the filed to the corresponding

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-29 Thread Qian Zhang
> On Feb. 25, 2016, 11:32 p.m., Avinash sridharan wrote: > > include/mesos/v1/mesos.proto, line 1573 > > > > > > Ditto. Agree. - Qian --- This is an

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120810 --- include/mesos/mesos.proto (line 1577)

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120776 --- Patch looks great! Reviews applied: [44004] Passed command:

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120710 --- include/mesos/mesos.proto (line 1576)

Review Request 44004: Add 'name' field into NetworkInfo.

2016-02-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-4758