Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-16 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/
---

(Updated March 16, 2016, 8:03 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
---

Windows: Added Socket compatibility `#define`s to windows.hpp.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 

Diff: https://reviews.apache.org/r/44078/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-15 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/#review123796
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 11, 2016, 6:39 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44078/
> ---
> 
> (Updated March 11, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Socket compatibility `#define`s to windows.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 
> 
> Diff: https://reviews.apache.org/r/44078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-11 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/
---

(Updated March 11, 2016, 6:39 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
---

Windows: Added Socket compatibility `#define`s to windows.hpp.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 

Diff: https://reviews.apache.org/r/44078/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-03-10 Thread Yi Sun

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/#review123006
---


Ship it!




Ship It!

- Yi Sun


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44078/
> ---
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Socket compatibility `#define`s to windows.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 
> 
> Diff: https://reviews.apache.org/r/44078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-02-26 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/#review120902
---



Bad patch!

Reviews applied: [44078, 44077, 44076, 44075, 44046, 44045, 42036]

Failed command: ./support/apply-review.sh -n -r 42036

Error:
2016-02-26 18:09:06 URL:https://reviews.apache.org/r/42036/diff/raw/ [570/570] 
-> "42036.patch" [1]
error: patch failed: src/CMakeLists.txt:197
error: src/CMakeLists.txt: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11671/console

- Mesos ReviewBot


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44078/
> ---
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Socket compatibility `#define`s to windows.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 
> 
> Diff: https://reviews.apache.org/r/44078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-02-26 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44078/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
---

Windows: Added Socket compatibility `#define`s to windows.hpp.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 

Diff: https://reviews.apache.org/r/44078/diff/


Testing
---


Thanks,

Alex Clemmer