Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-11 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/#review123253
---


Ship it!




Ship It!

- Ben Mahler


On March 11, 2016, 6:30 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44190/
> ---
> 
> (Updated March 11, 2016, 6:30 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4790
> https://issues.apache.org/jira/browse/MESOS-4790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `Bytes` usable in `constexpr` expressions [stout].
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 
> 
> Diff: https://reviews.apache.org/r/44190/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/
---

(Updated March 11, 2016, 6:30 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Split Duration changes into a separate patch.


Bugs: MESOS-4790
https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description (updated)
---

Made `Bytes` usable in `constexpr` expressions [stout].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 

Diff: https://reviews.apache.org/r/44190/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-10 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/#review123038
---




3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp (lines 170 - 177)


Could you split this change out into a separate patch?


- Ben Mahler


On March 1, 2016, 2:26 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44190/
> ---
> 
> (Updated March 1, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4790
> https://issues.apache.org/jira/browse/MESOS-4790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also marked a few Duration constants as `constexpr`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> ecec70672313666124ee6a951b3db09e9401b9ff 
> 
> Diff: https://reviews.apache.org/r/44190/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-10 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/#review123037
---


Ship it!




Ship It!

- Ben Mahler


On March 1, 2016, 2:26 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44190/
> ---
> 
> (Updated March 1, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4790
> https://issues.apache.org/jira/browse/MESOS-4790
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also marked a few Duration constants as `constexpr`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
> 88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> ecec70672313666124ee6a951b3db09e9401b9ff 
> 
> Diff: https://reviews.apache.org/r/44190/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-02-29 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44190/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4790
https://issues.apache.org/jira/browse/MESOS-4790


Repository: mesos


Description
---

Also marked a few Duration constants as `constexpr`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
88a8bd4019fcbdaa5fcde4867cee9a198c83c1c6 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
ecec70672313666124ee6a951b3db09e9401b9ff 

Diff: https://reviews.apache.org/r/44190/diff/


Testing
---

make check


Thanks,

Neil Conway