Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review123161 --- Fix it, then Ship it! src/slave/flags.hpp (lines 133 - 134)

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review122443 --- Ship it! Ship It! - Gilbert Song On March 4, 2016, 8:14

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-04 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review122122 --- Ship it! Ship It! - Avinash sridharan On March 4, 2016,

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- (Updated March 5, 2016, 12:14 a.m.) Review request for mesos, Avinash

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-04 Thread Avinash sridharan
> On March 2, 2016, 4:07 p.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 694 > > > > > > s/directory/location > > > > remove this line: > > This flag is used for\n" > > "the

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- (Updated March 4, 2016, 10:36 a.m.) Review request for mesos, Avinash

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
> On March 3, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 694 > > > > > > s/directory/location > > > > remove this line: > > This flag is used for\n" > > "the

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Qian Zhang
> On March 2, 2016, 1:03 a.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 698-705 > > > > > > While users can config the CNI network form a JSON file, is it possible > > to provide an option to define the

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Avinash sridharan
> On March 1, 2016, 5:03 p.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 698-705 > > > > > > While users can config the CNI network form a JSON file, is it possible > > to provide an option to define the

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-03 Thread Avinash sridharan
> On March 2, 2016, 4:07 p.m., Avinash sridharan wrote: > > docs/endpoints/slave/state.json.md, line 91 > > > > > > Do we need to change some install scripts to create these paths? I > > think we should leave the

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-02 Thread Qian Zhang
> On March 3, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 690 > > > > > > Maybe s/Directory path/Location ? I just followed the existing convention, please see the help message of

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-02 Thread Qian Zhang
> On March 2, 2016, 1:03 a.m., Gilbert Song wrote: > > src/slave/flags.hpp, lines 132-133 > > > > > > Thinking about a proper naming. Consider remove `_dir`? I see there are already a couple of flags named with

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121661 --- docs/configuration.md (line 1305)

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121411 --- Patch looks great! Reviews applied: [44200] Passed command:

Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

2016-02-29 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: