Re: Review Request 44223: Modified executor library to read grace period from environment.
> On March 1, 2016, 8:24 p.m., Vinod Kone wrote: > > tnis should come after the next review. My bad, fixed. - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/#review121488 --- On March 1, 2016, 9:15 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44223/ > --- > > (Updated March 1, 2016, 9:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-4829 > https://issues.apache.org/jira/browse/MESOS-4829 > > > Repository: mesos > > > Description > --- > > This change modifies the executor library to read shutdown grace > period from the environment instead of reading it from the `Shutdown` > event in executor protobuf. > > > Diffs > - > > src/executor/executor.cpp c5f22e732259da814170677ea8ef85db1edac686 > > Diff: https://reviews.apache.org/r/44223/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 44223: Modified executor library to read grace period from environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/ --- (Updated March 1, 2016, 9:15 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. Changes --- Fixed Deps Bugs: MESOS-4829 https://issues.apache.org/jira/browse/MESOS-4829 Repository: mesos Description --- This change modifies the executor library to read shutdown grace period from the environment instead of reading it from the `Shutdown` event in executor protobuf. Diffs (updated) - src/executor/executor.cpp c5f22e732259da814170677ea8ef85db1edac686 Diff: https://reviews.apache.org/r/44223/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 44223: Modified executor library to read grace period from environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/#review121489 --- Ship it! Ship It! - Vinod Kone On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44223/ > --- > > (Updated March 1, 2016, 8:04 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-4829 > https://issues.apache.org/jira/browse/MESOS-4829 > > > Repository: mesos > > > Description > --- > > This change modifies the executor library to read shutdown grace > period from the environment instead of reading it from the `Shutdown` > event in executor protobuf. > > > Diffs > - > > src/executor/executor.cpp c5f22e732259da814170677ea8ef85db1edac686 > > Diff: https://reviews.apache.org/r/44223/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Review Request 44223: Modified executor library to read grace period from environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone. Bugs: MESOS-4829 https://issues.apache.org/jira/browse/MESOS-4829 Repository: mesos Description --- This change modifies the executor library to read shutdown grace period from the environment instead of reading it from the `Shutdown` event in executor protobuf. Diffs - src/executor/executor.cpp c5f22e732259da814170677ea8ef85db1edac686 Diff: https://reviews.apache.org/r/44223/diff/ Testing --- make check Thanks, Anand Mazumdar
