Re: Review Request 44226: Modified tests to remove `Shutdown` event.

2016-03-01 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44226/#review121531
---



Patch looks great!

Reviews applied: [44222, 44224, 44223, 44225, 44226]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44226/
> ---
> 
> (Updated March 1, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing tests to not rely on the `Shutdown` event
> in the executor protobufs.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44226/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 44226: Modified tests to remove `Shutdown` event.

2016-03-01 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44226/#review121491
---


Ship it!




Ship It!

- Vinod Kone


On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44226/
> ---
> 
> (Updated March 1, 2016, 8:04 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing tests to not rely on the `Shutdown` event
> in the executor protobufs.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 
>   src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 
> 
> Diff: https://reviews.apache.org/r/44226/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 44226: Modified tests to remove `Shutdown` event.

2016-03-01 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44226/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829


Repository: mesos


Description
---

This change modifies the existing tests to not rely on the `Shutdown` event
in the executor protobufs.


Diffs
-

  src/tests/mesos.hpp 0c55d5901753dc3f6e71486f727a2af7bd920429 
  src/tests/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb 

Diff: https://reviews.apache.org/r/44226/diff/


Testing
---

make check


Thanks,

Anand Mazumdar