Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review122081 --- Ship it! Ship It! - Till Toenshoff On March 4, 2016, 3:07 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44227/ > --- > > (Updated March 4, 2016, 3:07 p.m.) > > > Review request for mesos, Anand Mazumdar and Michael Park. > > > Bugs: MESOS-4002 > https://issues.apache.org/jira/browse/MESOS-4002 > > > Repository: mesos > > > Description > --- > > Calling .get() on a future is a blocking operation and a test calling get() > without prior waiting for the future (e.g., AWAIT_READY()) can block forever. > > > Diffs > - > > src/tests/reservation_endpoints_tests.cpp > f3a143812aa10bc445ac5d27c00318e91eb086aa > > Diff: https://reviews.apache.org/r/44227/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/ --- (Updated March 4, 2016, 3:07 p.m.) Review request for mesos, Anand Mazumdar and Michael Park. Bugs: MESOS-4002 https://issues.apache.org/jira/browse/MESOS-4002 Repository: mesos Description (updated) --- Calling .get() on a future is a blocking operation and a test calling get() without prior waiting for the future (e.g., AWAIT_READY()) can block forever. Diffs - src/tests/reservation_endpoints_tests.cpp f3a143812aa10bc445ac5d27c00318e91eb086aa Diff: https://reviews.apache.org/r/44227/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review121557 --- Patch looks great! Reviews applied: [44227] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 1, 2016, 9:24 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44227/ > --- > > (Updated March 1, 2016, 9:24 p.m.) > > > Review request for mesos, Anand Mazumdar and Michael Park. > > > Bugs: MESOS-4002 > https://issues.apache.org/jira/browse/MESOS-4002 > > > Repository: mesos > > > Description > --- > > Added AWAIT_READY() call to reservation_endpoint_tests. > > > Diffs > - > > src/tests/reservation_endpoints_tests.cpp > f3a143812aa10bc445ac5d27c00318e91eb086aa > > Diff: https://reviews.apache.org/r/44227/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review121496 --- Ship it! Ship It! - Anand Mazumdar On March 1, 2016, 9:24 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44227/ > --- > > (Updated March 1, 2016, 9:24 p.m.) > > > Review request for mesos, Anand Mazumdar and Michael Park. > > > Bugs: MESOS-4002 > https://issues.apache.org/jira/browse/MESOS-4002 > > > Repository: mesos > > > Description > --- > > Added AWAIT_READY() call to reservation_endpoint_tests. > > > Diffs > - > > src/tests/reservation_endpoints_tests.cpp > f3a143812aa10bc445ac5d27c00318e91eb086aa > > Diff: https://reviews.apache.org/r/44227/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/ --- Review request for mesos, Anand Mazumdar and Michael Park. Bugs: MESOS-4002 https://issues.apache.org/jira/browse/MESOS-4002 Repository: mesos Description --- Added AWAIT_READY() call to reservation_endpoint_tests. Diffs - src/tests/reservation_endpoints_tests.cpp f3a143812aa10bc445ac5d27c00318e91eb086aa Diff: https://reviews.apache.org/r/44227/diff/ Testing --- make check Thanks, Joerg Schad
