Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

> On March 2, 2016, 1:31 a.m., Joseph Wu wrote:
> > src/slave/containerizer/docker.cpp, lines 585-586
> > 
> >
> > It would be a slightly stronger check if you include this as well:
> > ```
> > strings::startsWith(entry.root, volumesRootDir)
> > ```
> > 
> > I added `paths::getVolumeRootDir` here:
> > https://reviews.apache.org/r/44196/

SG. Added a TODO.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121527
---


On March 1, 2016, 11:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44232/
> ---
> 
> (Updated March 1, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Timothy Chen.
> 
> 
> Bugs: MESOS-4832
> https://issues.apache.org/jira/browse/MESOS-4832
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a check when umounting persistent volumes in docker containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
>   src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 
> 
> Diff: https://reviews.apache.org/r/44232/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121554
---


Ship it!




Ship It!

- Timothy Chen


On March 1, 2016, 11:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44232/
> ---
> 
> (Updated March 1, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Timothy Chen.
> 
> 
> Bugs: MESOS-4832
> https://issues.apache.org/jira/browse/MESOS-4832
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a check when umounting persistent volumes in docker containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
>   src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 
> 
> Diff: https://reviews.apache.org/r/44232/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/
---

(Updated March 1, 2016, 11:50 p.m.)


Review request for mesos, Joseph Wu and Timothy Chen.


Changes
---

Added a TODO about making slave's work_dir a slave+shared mount.


Bugs: MESOS-4832
https://issues.apache.org/jira/browse/MESOS-4832


Repository: mesos


Description (updated)
---

Added a check when umounting persistent volumes in docker containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 

Diff: https://reviews.apache.org/r/44232/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/
---

Review request for mesos, Joseph Wu and Timothy Chen.


Bugs: MESOS-4832
https://issues.apache.org/jira/browse/MESOS-4832


Repository: mesos


Description
---

Added a check when umounting persistent volumes in docker containerizer.

See ticket for details.


Diffs
-

  src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b 
  src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc 

Diff: https://reviews.apache.org/r/44232/diff/


Testing
---

sudo make check


Thanks,

Jie Yu