Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121757 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 7:17 p.m.) Review request for mesos and Joris Van

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
> On March 2, 2016, 1:11 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1421 > > > > > > One suggestion is that does it make sense to update all variables > > including `scalar` to

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 7:15 p.m.) Review request for mesos and Joris Van

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121633 --- src/master/allocator/mesos/hierarchical.cpp (line 1419)

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121628 --- Patch looks great! Reviews applied: [43684, 43685, 43686, 44250,

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 6:21 a.m.) Review request for mesos and Joris Van

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121588 --- src/master/allocator/mesos/hierarchical.cpp (line 1226)

Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4833