Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-10 Thread Jie Yu
> On March 11, 2016, 12:43 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 572-578 > > > > > > No need for this? I'll fix it for you. - Jie

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/#review123048 --- Fix it, then Ship it! Ship It!

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
> On March 8, 2016, 1:57 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 590-591 > > > > > > Looking at the original code, why do we need this id? Should that > > always be the

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- (Updated March 8, 2016, 10:49 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/#review122024 --- Patch looks great! Reviews applied: [44239, 44298, 43969, 44299]

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-03 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- (Updated March 3, 2016, 11:37 p.m.) Review request for mesos and Jie Yu.

Review Request 44299: Added unit test for file URI fetcher.

2016-03-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---