Re: Review Request 44315: Do not traverse offer list if there is only one offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/#review141574 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On March 14, 2016, 4:44 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44315/ > --- > > (Updated March 14, 2016, 4:44 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-4845 > https://issues.apache.org/jira/browse/MESOS-4845 > > > Repository: mesos > > > Description > --- > > Do not traverse offer list if there is only one offer. > > > Diffs > - > > src/tests/master_maintenance_tests.cpp > 5a421d4e8740b5105518283943087869025cbfa6 > > Diff: https://reviews.apache.org/r/44315/diff/ > > > Testing > --- > > make > make check > ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" > > > Thanks, > > Guangya Liu > >
Re: Review Request 44315: Do not traverse offer list if there is only one offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/#review123388 --- Patch looks great! Reviews applied: [44315] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 14, 2016, 4:44 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44315/ > --- > > (Updated March 14, 2016, 4:44 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-4845 > https://issues.apache.org/jira/browse/MESOS-4845 > > > Repository: mesos > > > Description > --- > > Do not traverse offer list if there is only one offer. > > > Diffs > - > > src/tests/master_maintenance_tests.cpp > 5a421d4e8740b5105518283943087869025cbfa6 > > Diff: https://reviews.apache.org/r/44315/diff/ > > > Testing > --- > > make > make check > ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" > > > Thanks, > > Guangya Liu > >
Re: Review Request 44315: Do not traverse offer list if there is only one offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- (Updated 三月 14, 2016, 4:44 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4845 https://issues.apache.org/jira/browse/MESOS-4845 Repository: mesos Description --- Do not traverse offer list if there is only one offer. Diffs (updated) - src/tests/master_maintenance_tests.cpp 5a421d4e8740b5105518283943087869025cbfa6 Diff: https://reviews.apache.org/r/44315/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" Thanks, Guangya Liu
Re: Review Request 44315: Do not traverse offer list if there is only one offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- (Updated 三月 3, 2016, 7:01 a.m.) Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-4845 https://issues.apache.org/jira/browse/MESOS-4845 Repository: mesos Description --- Do not traverse offer list if there is only one offer. Diffs - src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c Diff: https://reviews.apache.org/r/44315/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" Thanks, Guangya Liu
Review Request 44315: Do not traverse offer list if there is only one offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Do not traverse offer list if there is only one offer. Diffs - src/tests/master_maintenance_tests.cpp 3faa8136cf57276295553910319480028f433e4c Diff: https://reviews.apache.org/r/44315/diff/ Testing --- make make check ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" Thanks, Guangya Liu
