Re: Review Request 44421: Added support for "overlay" keyword.

> On March 29, 2016, 4:42 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/provisioner/backend.cpp, line 50 > > > > > > Why do you need to test overlay fs support in create()? If kernel > > doesn't support th

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review126264 --- Fix it, then Ship it! src/linux/fs.hpp (lines 365 - 366)

Re: Review Request 44421: Added support for "overlay" keyword.

> On 三月 29, 2016, 4:42 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/provisioner/backend.cpp, line 50 > > > > > > Why do you need to test overlay fs support in create()? If kernel > > doesn't support this,

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review125811 --- src/slave/containerizer/mesos/provisioner/backend.cpp (line 50) <

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review125800 --- @jieyu, can you please help check if we can merge this, this can h

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124206 --- src/linux/fs.hpp (lines 160 - 161)

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124214 --- Ship it! Ship It! - Gilbert Song On March 18, 2016, 9:22 a.m

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124155 --- Is this chunk of code testable? - Jay Guo On March 11, 2016, 11

Re: Review Request 44421: Added support for "overlay" keyword.

> On 三月 18, 2016, 8:59 a.m., Jay Guo wrote: > > Is this chunk of code testable? Yes, it was already coveredy by src/tests/environment.cpp - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124140 --- src/linux/fs.cpp (line 74)

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 18, 2016, 4:22 p.m.) Review request for mesos, haosdent huang, Jie

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review123133 --- Ship it! Ship It! - haosdent huang On March 11, 2016, 11:58

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 11, 2016, 11:58 a.m.) Review request for mesos, haosdent huang, Jie

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review123032 --- src/linux/fs.hpp (lines 155 - 156)

Re: Review Request 44421: Added support for "overlay" keyword.

> On 三月 5, 2016, 9:13 a.m., haosdent huang wrote: > > I agree this could works completely. But I not sure whether we have a > > better way to add something like `overlayfs::supported()`? Because some > > guys may forgor this and continue us `fs::supported("overlayfs")` in the > > future. > >

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review122195 --- I agree this could works completely. But I not sure whether we hav

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review122193 --- Patch looks great! Reviews applied: [44421] Passed command: expo

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 5, 2016, 8:04 a.m.) Review request for mesos, haosdent huang, Jie Y

Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin. Bugs: MESOS-48