Re: Review Request 44512: Support to get weights info by /weights.

2016-04-10 Thread Adam B
> On April 10, 2016, 12:53 a.m., Adam B wrote: > > src/master/weights_handler.cpp, line 71 > > > > > > I wonder if `jsonify(weightInfos)` would work here Nope. Nevermind. - Adam

Re: Review Request 44512: Support to get weights info by /weights.

2016-04-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review128020 --- Fix it, then Ship it! Looks great! I'm testing a build now

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-23 Thread Yongqiao Wang
> On March 21, 2016, 9:03 a.m., Adam B wrote: > > Good start, but you're missing a few things. Are these coming in subsequent > > patches? > > - Authentication for GET requests > > - Tests for GETs > > - Documentation updates > > Yongqiao Wang wrote: > I will add a separated patch for GET

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-22 Thread Yongqiao Wang
> On March 21, 2016, 9:03 a.m., Adam B wrote: > > Good start, but you're missing a few things. Are these coming in subsequent > > patches? > > - Authentication for GET requests > > - Tests for GETs > > - Documentation updates I will add a separated patch for GET requet test. > On March 21,

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-22 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- (Updated March 22, 2016, 10:02 a.m.) Review request for mesos and Adam B.

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review124512 --- Good start, but you're missing a few things. Are these coming in

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- (Updated March 9, 2016, 6:36 a.m.) Review request for mesos and Adam B.

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review122584 --- Patch looks great! Reviews applied: [41681, 43863, 44512]

Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- Review request for mesos and Adam B. Bugs: MESOS-4316