Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review124849 --- src/Makefile.am (line 788)

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 17, 2016, 3:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > > > > > I don't think we put headers here. > > Qian Zhang wrote: > I had the same concern before, because it seems most source

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 17, 2016, 11:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > > > > > I don't think we put headers here. I had the same concern before, because it seems most source files here are .cpp. But I

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 17, 2016, 4:56 p.m.) Review request for mesos, Avinash

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123972 --- Fix it, then Ship it! src/CMakeLists.txt (line 279)

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 16, 2016, 10:09 a.m.) Review request for mesos, Avinash

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 15, 2016, 11:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 40 > > > > > > Why are the position identifiers not sequential ? Sorry, my bad, will

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 15, 2016, 11:28 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, lines 45-46 > > > > > > The isolator doesn't actually need the IPAM or the DNS

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123664 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123662 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 12, 2016, 2:19 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, lines 45-55 > > > > > > What's this? This is flannel plugin specific, let me remove it too. - Qian

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 15, 2016, 10:05 p.m.) Review request for mesos, Avinash

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 11, 2016, 11:43 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 46 > > > > > > Can we list the required field before the optional fields? We can keep >

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 11, 2016, 6:19 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 23 > > > > > > OK, this is my bad. I didn't realize that network configuration JSON > > will inline

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123190 --- src/slave/containerizer/mesos/isolators/network/spec.proto

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123170 --- src/CMakeLists.txt (line 52)

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 11, 2016, 3:43 p.m., Avinash sridharan wrote: > > Can you remove the dependency from 44200? - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123148

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review123148 --- src/CMakeLists.txt (line 52)

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 10, 2016, 10:44 p.m.) Review request for mesos, Avinash

Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: