Re: Review Request 44672: Added normalize method to registry puller.

2016-03-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124818 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 7:06 p.m.,

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 21, 2016, 12:06 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124567 ---

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 20, 2016, 11:44 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song
> On March 19, 2016, 10:45 a.m., Jie Yu wrote: > > Please add a test to test if we can properly handle images like 'alpine' > > directly without the 'library/' prefix. Test was in patch #44673. - Gilbert --- This is an automatically

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song
> On March 18, 2016, 11:54 p.m., Shuai Lin wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 182 > > > > > > I would suggest to add a new test for the `normalize` function. >

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Guangya Liu
> On 三月 19, 2016, 6:54 a.m., Shuai Lin wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 182 > > > > > > I would suggest to add a new test for the `normalize` function. I

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123690 --- Please add a test to test if we can properly handle images like

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124379 ---

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 14, 2016, 5:32 p.m.) Review request for mesos, Artem

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123307 --- Can you please link

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123295 --- Ship it! Ship It! - haosdent huang On March 10, 2016, 11:49

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 10, 2016, 3:49 p.m.) Review request for mesos, Artem

Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123019 ---

Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.