Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review124039
---


Ship it!




Ship It!

- Michael Park


On March 10, 2016, 9:59 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review123054
---



Patch looks great!

Reviews applied: [44675]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 9:59 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 9:59 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/
---

(Updated March 10, 2016, 9:59 p.m.)


Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.


Changes
---

Address review comments


Bugs: MESOS-4740
https://issues.apache.org/jira/browse/MESOS-4740


Repository: mesos


Description
---

Updated `/metrics/snapshot` endpoint to use `jsonify`.


Diffs (updated)
-

  3rdparty/libprocess/src/metrics/metrics.cpp 
f1e6774ebf8670b006ba6ea181439d0ef1529b40 

Diff: https://reviews.apache.org/r/44675/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

> On March 10, 2016, 9:32 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234
> > 
> >
> > (1) Why not just `snapshot`?
> > (2) We don't use default capture by reference. Could you explicitly 
> > list the variables that need to be captured here?
> 
> Cong Wang wrote:
> 1. Fixed
> 
> 2. We need to capture all the function parameters, and in this context it 
> equals to capture all. So I don't think it makes sense to list them one by 
> one?

Oh, we can actually save one here... I will change as you suggest.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review122996
---


On March 10, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

> On March 10, 2016, 9:32 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234
> > 
> >
> > (1) Why not just `snapshot`?
> > (2) We don't use default capture by reference. Could you explicitly 
> > list the variables that need to be captured here?

1. Fixed

2. We need to capture all the function parameters, and in this context it 
equals to capture all. So I don't think it makes sense to list them one by one?


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review122996
---


On March 10, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/#review122996
---




3rdparty/libprocess/src/metrics/metrics.cpp (line 234)


(1) Why not just `snapshot`?
(2) We don't use default capture by reference. Could you explicitly list 
the variables that need to be captured here?


- Michael Park


On March 10, 2016, 8:19 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44675/
> ---
> 
> (Updated March 10, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/metrics/snapshot` endpoint to use `jsonify`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f1e6774ebf8670b006ba6ea181439d0ef1529b40 
> 
> Diff: https://reviews.apache.org/r/44675/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44675/
---

Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-4740
https://issues.apache.org/jira/browse/MESOS-4740


Repository: mesos


Description
---

Updated `/metrics/snapshot` endpoint to use `jsonify`.


Diffs
-

  3rdparty/libprocess/src/metrics/metrics.cpp 
f1e6774ebf8670b006ba6ea181439d0ef1529b40 

Diff: https://reviews.apache.org/r/44675/diff/


Testing
---

make check


Thanks,

Cong Wang