Re: Review Request 44797: Updated libprocess makefile to include device_tests.cpp.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44797/#review123486
---



The order of reviewboard dependencies is wrong in this patch.  This patch 
actually depends on 44797, not the other way around as it is now. Did you use 
support/post-reviews.py to post these patches?  Usually, it sets the 
"Depends-On" and "Blocked-By" fields properly for your commit chain.


That said, I talked to Ben, and he agress that the new types for `Selector` and 
`Access` should not live in stout, but rather in `src/linux/cgroups.hpp`, 
making this patch unnecessary.  It should likely be discarded.


3rdparty/libprocess/3rdparty/Makefile.am (line 166)


Reviewboard is marking this as incorrect spacing, but I downloaded it 
locally, and everything looks good.

For future reference to people watching this review: to get the right 
spacing, you should set your tabspace=8 and then tab out until the '\'s all 
line up.


- Kevin Klues


On March 14, 2016, 6:17 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44797/
> ---
> 
> (Updated March 14, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated libprocess makefile to include device_tests.cpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
> 
> Diff: https://reviews.apache.org/r/44797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 44797: Updated libprocess makefile to include device_tests.cpp.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44797/
---

Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas 
Nielsen.


Bugs: MESOS-3368
https://issues.apache.org/jira/browse/MESOS-3368


Repository: mesos


Description
---

Updated libprocess makefile to include device_tests.cpp.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 

Diff: https://reviews.apache.org/r/44797/diff/


Testing
---


Thanks,

Abhishek Dasgupta