Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136187
---


Ship it!




Ship It!

- Michael Park


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp d5dc49f045a1e74ed7b97f90330bec7eab81b382 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a52b35c5c79ccd80dcce3e5f01656081972423fb 
>   src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
>   src/log/tool/benchmark.cpp 7e1350675bdfe6c44e86b082bc01f692cc72b850 
>   src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
>   src/log/tool/initialize.cpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?
> 
> Tomasz Janiszewski wrote:
> I run only sed on src. Other patches could be discarded since clang-tidy 
> doesn't report 0 to nullptr fixes.
> 
> Michael Park wrote:
> What does this mean?
> > clang-tidy doesn't report 0 to nullptr fixes.
> 
> Tomasz Janiszewski wrote:
> I run clang tidy after changes made by sed and it doesn't change anything.
> 
> Michael Park wrote:
> Ah I see what you mean. I was asking because I was hoping to capture the 
> limitations of `clang-tidy` at least as of now.
> That is, the `sed` patch (which would be subsequent to the `clang-tidy` 
> patch) would capture the cases that `clang-tidy` for whatever reason misses.
> 
> Tomasz Janiszewski wrote:
> Exactly. I hoped some 0 could be replaced with `nullptr` but this didn't 
> happen. BTW clang tidy could be used in CI to automatically detect `NULL` and 
> `0` where `nullptr` could be used.

Ok, let's keep this as-is then. Thanks!


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

> On Cze 4, 2016, 7:14 po południu, Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?
> 
> Tomasz Janiszewski wrote:
> I run only sed on src. Other patches could be discarded since clang-tidy 
> doesn't report 0 to nullptr fixes.
> 
> Michael Park wrote:
> What does this mean?
> > clang-tidy doesn't report 0 to nullptr fixes.
> 
> Tomasz Janiszewski wrote:
> I run clang tidy after changes made by sed and it doesn't change anything.
> 
> Michael Park wrote:
> Ah I see what you mean. I was asking because I was hoping to capture the 
> limitations of `clang-tidy` at least as of now.
> That is, the `sed` patch (which would be subsequent to the `clang-tidy` 
> patch) would capture the cases that `clang-tidy` for whatever reason misses.

Exactly. I hoped some 0 could be replaced with `nullptr` but this didn't 
happen. BTW clang tidy could be used in CI to automatically detect `NULL` and 
`0` where `nullptr` could be used.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On Cze 4, 2016, 12:59 po południu, Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated Cze 4, 2016, 12:59 po południu)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?
> 
> Tomasz Janiszewski wrote:
> I run only sed on src. Other patches could be discarded since clang-tidy 
> doesn't report 0 to nullptr fixes.
> 
> Michael Park wrote:
> What does this mean?
> > clang-tidy doesn't report 0 to nullptr fixes.
> 
> Tomasz Janiszewski wrote:
> I run clang tidy after changes made by sed and it doesn't change anything.

Ah I see what you mean. I was asking because I was hoping to capture the 
limitations of `clang-tidy` at least as of now.
That is, the `sed` patch (which would be subsequent to the `clang-tidy` patch) 
would capture the cases that `clang-tidy` for whatever reason misses.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

> On Cze 4, 2016, 7:14 po południu, Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?
> 
> Tomasz Janiszewski wrote:
> I run only sed on src. Other patches could be discarded since clang-tidy 
> doesn't report 0 to nullptr fixes.
> 
> Michael Park wrote:
> What does this mean?
> > clang-tidy doesn't report 0 to nullptr fixes.

I run clang tidy after changes made by sed and it doesn't change anything.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On Cze 4, 2016, 12:59 po południu, Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated Cze 4, 2016, 12:59 po południu)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   

Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

> On June 4, 2016, 7:14 p.m., Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?
> 
> Tomasz Janiszewski wrote:
> I run only sed on src. Other patches could be discarded since clang-tidy 
> doesn't report 0 to nullptr fixes.

What does this mean?
> clang-tidy doesn't report 0 to nullptr fixes.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

> On Cze 4, 2016, 7:14 po południu, Michael Park wrote:
> > Could you please split this up into `clang-tidy` and `sed`?
> > 
> > This only touches mesos, not libprocess and stout. Is that correct?
> > 
> > Are https://reviews.apache.org/r/45482/ and 
> > https://reviews.apache.org/r/45480/ meant to be discarded now?

I run only sed on src. Other patches could be discarded since clang-tidy 
doesn't report 0 to nullptr fixes.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---


On Cze 4, 2016, 12:59 po południu, Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated Cze 4, 2016, 12:59 po południu)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136178
---



Could you please split this up into `clang-tidy` and `sed`?

This only touches mesos, not libprocess and stout. Is that correct?

Are https://reviews.apache.org/r/45482/ and https://reviews.apache.org/r/45480/ 
meant to be discarded now?

- Michael Park


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp d5dc49f045a1e74ed7b97f90330bec7eab81b382 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a52b35c5c79ccd80dcce3e5f01656081972423fb 
>   src/log/tool/benchmark.hpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136167
---



Patch looks great!

Reviews applied: [44843]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 4, 2016, 12:59 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
>   src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 5fac65fd4ab60144da4e06ae080a168a835b9ac0 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
>   src/examples/test_http_authenticator_module.cpp 
> 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_master_contender_module.cpp 
> d50d9d820de8140ada6383e103cac1e651c4c75e 
>   src/examples/test_master_detector_module.cpp 
> ff362db679803fc77b029ae4355ebb40e36a097c 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
>   src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 341df13349d56d3c416107e8889ef543b6371eb0 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 728e93523e2bc9adb06bb62c4491ac3a29712961 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 5a3805fef57e429b9cb105ba704d1af69b25b4d4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 5cce558b42f396aa4e99f750bab38d556bda9196 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp d5dc49f045a1e74ed7b97f90330bec7eab81b382 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a52b35c5c79ccd80dcce3e5f01656081972423fb 
>   src/log/tool/benchmark.hpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/
---

(Updated June 4, 2016, 12:59 p.m.)


Review request for mesos and Michael Park.


Changes
---

Update patch


Bugs: MESOS-3243
https://issues.apache.org/jira/browse/MESOS-3243


Repository: mesos


Description
---

RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'


Diffs (updated)
-

  src/authentication/cram_md5/authenticatee.cpp 
7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
  src/authentication/cram_md5/authenticator.cpp 
027eba4f433fff328d68c41005bc59c41c7ae668 
  src/authentication/cram_md5/auxprop.cpp 
d82d2d2f7793859772d89cc91bee09240624c613 
  src/authorizer/local/authorizer.cpp 32346bbaf75dce0cbe1676ba515aa8455bfdc54c 
  src/examples/balloon_executor.cpp 108ebd9afec5b2d592ffbe5c150a9271f1899f2c 
  src/examples/example_module_impl.cpp aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
  src/examples/load_generator_framework.cpp 
5fac65fd4ab60144da4e06ae080a168a835b9ac0 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/examples/test_anonymous_module.cpp 
dd291cff3b5d47337e371cd2c1082fd6716af3fc 
  src/examples/test_authorizer_module.cpp 
19ec7cd114562f74c660b83b39235127d25001ee 
  src/examples/test_container_logger_module.cpp 
76dd494fa4c32514ba14b1f4498b588ac9051b4d 
  src/examples/test_hook_module.cpp bc0bcb91eec0e2f666a76565b6cb3bb374f5b373 
  src/examples/test_http_authenticator_module.cpp 
8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4 
  src/examples/test_isolator_module.cpp 
a4a2103b1e449837b95948c8b5c25e05c5d13860 
  src/examples/test_master_contender_module.cpp 
d50d9d820de8140ada6383e103cac1e651c4c75e 
  src/examples/test_master_detector_module.cpp 
ff362db679803fc77b029ae4355ebb40e36a097c 
  src/examples/test_qos_controller_module.cpp 
f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
  src/examples/test_resource_estimator_module.cpp 
229b2931e9129c194850f04051060d33bfa06570 
  src/exec/exec.cpp 666b1f47cf2d00bd3d80287cfe0221b3c834af86 
  src/files/files.hpp a41c203349bac0f12ef574fceb201dd08dd957fc 
  src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
  src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
  src/java/jni/org_apache_mesos_Log.cpp 
341df13349d56d3c416107e8889ef543b6371eb0 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
728e93523e2bc9adb06bb62c4491ac3a29712961 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
5a3805fef57e429b9cb105ba704d1af69b25b4d4 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
5cce558b42f396aa4e99f750bab38d556bda9196 
  src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
  src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
  src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
  src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
  src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
  src/linux/perf.cpp 2364ab5f277354d037376e0cec36fd7138a9e7fa 
  src/linux/routing/diagnosis/diagnosis.cpp 
8b86a8864c08b078425dcc242d323763d6ec15dd 
  src/linux/routing/filter/internal.hpp 
8690bf56472c318e85afb53d35494790ae4da27b 
  src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
  src/linux/routing/link/internal.hpp 8f05e5f513208c8f966bc324c9fe994a5807b051 
  src/linux/routing/queueing/internal.hpp 
768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
  src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
  src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp d5dc49f045a1e74ed7b97f90330bec7eab81b382 
  src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
  src/log/log.cpp a52b35c5c79ccd80dcce3e5f01656081972423fb 
  src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
  src/log/tool/benchmark.cpp 7e1350675bdfe6c44e86b082bc01f692cc72b850 
  src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
  src/log/tool/initialize.cpp e980772c29ead115fa5da836792281d4336d857f 
  src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
  src/log/tool/read.cpp 415038dfce36ef40f1388af98fcb923da2bbc59a 
  src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
  src/log/tool/replica.cpp 11aef65dc71a51b3e38afe6a31de2944f3799711 
  src/logging/logging.cpp 7ea189950bc3c5b0bb0a31f761ad24ab6e076a77 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  

Re: Review Request 44843: Replace NULL with nullptr.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review136159
---



Bad patch!

Reviews applied: [44843]

Failed command: ./support/apply-review.sh -n -r 44843

Error:
2016-06-04 10:33:31 URL:https://reviews.apache.org/r/44843/diff/raw/ 
[187556/187556] -> "44843.patch" [1]
error: patch failed: src/authentication/cram_md5/authenticatee.cpp:98
error: src/authentication/cram_md5/authenticatee.cpp: patch does not apply
error: patch failed: src/authentication/cram_md5/auxprop.cpp:182
error: src/authentication/cram_md5/auxprop.cpp: patch does not apply
error: patch failed: src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp:104
error: src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp: patch does not 
apply
error: patch failed: src/launcher/executor.cpp:273
error: src/launcher/executor.cpp: patch does not apply
error: patch failed: src/linux/fs.cpp:291
error: src/linux/fs.cpp: patch does not apply
error: patch failed: src/local/local.cpp:112
error: src/local/local.cpp: patch does not apply
error: patch failed: src/logging/logging.cpp:214
error: src/logging/logging.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:73
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
error: src/master/contender.hpp: does not exist in index
error: patch failed: src/master/http.cpp:588
error: src/master/http.cpp: patch does not apply
error: patch failed: src/master/master.cpp:1245
error: src/master/master.cpp: patch does not apply
error: patch failed: src/master/validation.cpp:621
error: src/master/validation.cpp: patch does not apply
error: patch failed: 
src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp:121
error: src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp: 
patch does not apply
error: patch failed: src/slave/container_loggers/lib_logrotate.cpp:281
error: src/slave/container_loggers/lib_logrotate.cpp: patch does not apply
error: patch failed: 
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp:360
error: src/slave/containerizer/mesos/isolators/filesystem/linux.cpp: patch does 
not apply
error: patch failed: src/slave/slave.cpp:171
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/container_logger_tests.cpp:458
error: src/tests/container_logger_tests.cpp: patch does not apply
error: patch failed: src/tests/slave_tests.cpp:2154
error: src/tests/slave_tests.cpp: patch does not apply
error: src/zookeeper/zookeeper.hpp: does not exist in index

Full log: https://builds.apache.org/job/mesos-reviewbot/13528/console

- Mesos ReviewBot


On June 4, 2016, 10:15 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated June 4, 2016, 10:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   include/mesos/module.hpp 30a9674686221d25132368e6c10664daa9cd6dc0 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/linux/perf.cpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/
---

(Updated June 4, 2016, 10:15 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3243
https://issues.apache.org/jira/browse/MESOS-3243


Repository: mesos


Description
---

RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'


Diffs
-

  include/mesos/module.hpp 30a9674686221d25132368e6c10664daa9cd6dc0 
  src/authentication/cram_md5/authenticatee.cpp 
7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
  src/authentication/cram_md5/authenticator.cpp 
027eba4f433fff328d68c41005bc59c41c7ae668 
  src/authentication/cram_md5/auxprop.cpp 
d82d2d2f7793859772d89cc91bee09240624c613 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/examples/test_isolator_module.cpp 
a4a2103b1e449837b95948c8b5c25e05c5d13860 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
  src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
  src/java/jni/org_apache_mesos_Log.cpp 
140b950136417eed7cba363a89537ed2f33832ff 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
  src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
  src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
  src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
  src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/linux/routing/diagnosis/diagnosis.cpp 
8b86a8864c08b078425dcc242d323763d6ec15dd 
  src/linux/routing/filter/internal.hpp 
8690bf56472c318e85afb53d35494790ae4da27b 
  src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
  src/linux/routing/link/internal.hpp 8f05e5f513208c8f966bc324c9fe994a5807b051 
  src/linux/routing/queueing/internal.hpp 
768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
  src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
  src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
  src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
  src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
  src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
  src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
  src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
  src/master/allocator/mesos/hierarchical.hpp 
e979fdf60da1409d1c2d08f0e9f03cef067506dd 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
  src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
  src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
  src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
  src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
843771ae5b4f7e283d85c093e63c235dc753397d 
  src/python/executor/src/mesos/executor/module.cpp 
f8c63821db616475b95c3d1687893c251fa2daca 
  src/python/executor/src/mesos/executor/proxy_executor.cpp 
b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
  src/python/native_common/common.hpp 166adb32978260750898537e8f45e4f3bbd19c79 
  src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
78dc298ec19a61cd491b2b43b463db67528c5526 
  src/python/scheduler/src/mesos/scheduler/module.cpp 
62eaf3166c4ebef42665358e8da438b2e3afba20 
  src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 
3d8f3bfc9cbff761822580310432177d00450f51 
  src/sched/sched.cpp ade6907b299a327a7766f9a2159d61a709357d6e 
  src/scheduler/scheduler.cpp 13972449363b633f21ddec7649b1b170703c773a 
  src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

> On March 26, 2016, 7:10 p.m., Michael Park wrote:
> > src/exec/exec.cpp, lines 637-638
> > 
> >
> > This is clearly beyond just a `s/NULL/nullptr`. I assume this is 
> > `clang-tidy` magic, right?

Exactly


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review125535
---


On March 28, 2016, 8:42 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated March 28, 2016, 8:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'
> 
> 
> Diffs
> -
> 
>   include/mesos/module.hpp 30a9674686221d25132368e6c10664daa9cd6dc0 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
>   src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/filter/internal.hpp 
> 8690bf56472c318e85afb53d35494790ae4da27b 
>   src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
>   src/linux/routing/link/internal.hpp 
> 8f05e5f513208c8f966bc324c9fe994a5807b051 
>   src/linux/routing/queueing/internal.hpp 
> 768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
>   src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
>   src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
>   src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
>   src/master/allocator/mesos/hierarchical.hpp 
> e979fdf60da1409d1c2d08f0e9f03cef067506dd 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
>   src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
>   src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
> 843771ae5b4f7e283d85c093e63c235dc753397d 
>   src/python/executor/src/mesos/executor/module.cpp 
> f8c63821db616475b95c3d1687893c251fa2daca 
>   src/python/executor/src/mesos/executor/proxy_executor.cpp 
> b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
>   src/python/native_common/common.hpp 
> 166adb32978260750898537e8f45e4f3bbd19c79 
>   

Re: Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/
---

(Updated March 28, 2016, 8:42 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3243
https://issues.apache.org/jira/browse/MESOS-3243


Repository: mesos


Description (updated)
---

RUN: find . -name "*.[hc]pp" | xargs -P 4 sed -i 's/\bNULL\b/nullptr/g'


Diffs (updated)
-

  include/mesos/module.hpp 30a9674686221d25132368e6c10664daa9cd6dc0 
  src/authentication/cram_md5/authenticatee.cpp 
7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
  src/authentication/cram_md5/authenticator.cpp 
027eba4f433fff328d68c41005bc59c41c7ae668 
  src/authentication/cram_md5/auxprop.cpp 
d82d2d2f7793859772d89cc91bee09240624c613 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/examples/test_isolator_module.cpp 
a4a2103b1e449837b95948c8b5c25e05c5d13860 
  src/exec/exec.cpp 8f672602daf090dec032d2b684e407e5d043af9c 
  src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
  src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
  src/java/jni/org_apache_mesos_Log.cpp 
140b950136417eed7cba363a89537ed2f33832ff 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/jvm/jvm.hpp d5023e4050d109ca97cedb05f85e1c24202ac3b0 
  src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
  src/jvm/org/apache/zookeeper.hpp 7e9c3aaa9f0eed44994004f9e32ce7ce3cf6d335 
  src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
  src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
  src/linux/routing/diagnosis/diagnosis.cpp 
8b86a8864c08b078425dcc242d323763d6ec15dd 
  src/linux/routing/filter/internal.hpp 
8690bf56472c318e85afb53d35494790ae4da27b 
  src/linux/routing/internal.hpp 8f68119819f7c79ece1a13ac1894b1802ddc8e19 
  src/linux/routing/link/internal.hpp 8f05e5f513208c8f966bc324c9fe994a5807b051 
  src/linux/routing/queueing/internal.hpp 
768ed325f9b259e150779eb3ad74f4e5d4bcc7a2 
  src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
  src/linux/systemd.cpp 9f6e06cfcf6f5b38971ff75eb85326d043140b4b 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
  src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.hpp 3051b6ff025252d2c770b0a70d6a66f4f34d7e69 
  src/log/tool/initialize.hpp 99c80061442c6379978f907c80a7e9d54a015f04 
  src/log/tool/read.hpp 937ae8f15f5e2227247ab43aa24c887c13c3cf2c 
  src/log/tool/replica.hpp c25bb09abc4391614c7a35b9ca91d678a745ffdd 
  src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
  src/master/allocator/mesos/hierarchical.hpp 
e979fdf60da1409d1c2d08f0e9f03cef067506dd 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
  src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
  src/master/master.cpp 655b0b8d0156b44914578a1241beb1fb7c92ca23 
  src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
  src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
  src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
  src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
843771ae5b4f7e283d85c093e63c235dc753397d 
  src/python/executor/src/mesos/executor/module.cpp 
f8c63821db616475b95c3d1687893c251fa2daca 
  src/python/executor/src/mesos/executor/proxy_executor.cpp 
b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
  src/python/native_common/common.hpp 166adb32978260750898537e8f45e4f3bbd19c79 
  src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
78dc298ec19a61cd491b2b43b463db67528c5526 
  src/python/scheduler/src/mesos/scheduler/module.cpp 
62eaf3166c4ebef42665358e8da438b2e3afba20 
  src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 
3d8f3bfc9cbff761822580310432177d00450f51 
  src/sched/sched.cpp ade6907b299a327a7766f9a2159d61a709357d6e 
  src/scheduler/scheduler.cpp 13972449363b633f21ddec7649b1b170703c773a 
  src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/containerizer/docker.cpp c5007a311ae9c1766dd4522ccbddbdb506d4ae4e 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 

Re: Review Request 44843: Replace NULL with nullptr.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review125551
---



Bad patch!

Reviews applied: [44843]

Failed command: ./support/apply-review.sh -n -r 44843

Error:
2016-03-26 21:02:02 URL:https://reviews.apache.org/r/44843/diff/raw/ 
[212202/212202] -> "44843.patch" [1]
error: patch failed: src/slave/slave.cpp:651
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12159/console

- Mesos ReviewBot


On March 15, 2016, 9:15 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated March 15, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace NULLs with `run-clang-tidy.py` and then with sed
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 0f0d9276337858984f0b19a82ffca74ee84dc650 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 7d64b6617564f43ef383ee60d92da92b2c958c47 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_http_authenticator_module.cpp 
> 459b7046bd76d3043d2484a2dd30c10d7deaedd4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.cpp 909d34a0112b219456dce76126029c603077e66d 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/logging/logging.cpp 8d9e4e9b200a0df1c67d4e7cd57107b7780f9812 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/http.cpp 1c2ca334567611578d9c6edb9ee7b0f43f0f1e18 
>   src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa 
>   src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e 
>   src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
>   src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
>   

Re: Review Request 44843: Replace NULL with nullptr.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/#review125535
---




src/exec/exec.cpp (lines 637 - 638)


This is clearly beyond just a `s/NULL/nullptr`. I assume this is 
`clang-tidy` magic, right?



src/linux/fs.cpp (lines 587 - 589)


```
  Try mount =
fs::mount(None(), "/", None(), MS_REC | MS_SLAVE, nullptr);

  if (mount.isError()) {
...
  }
```



src/python/executor/src/mesos/executor/proxy_executor.cpp (lines 54 - 55)


Hm, how come these `NULL`s were not replaced?



src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp (line 335)


What about the `NULL` here?



src/tests/script.cpp (line 96)


Another instance of `NULL` not being replaced?



src/tests/zookeeper_test_server.cpp (line 115)


Another instance of `NULL` not replaced.


- Michael Park


On March 15, 2016, 9:15 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44843/
> ---
> 
> (Updated March 15, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
> https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace NULLs with `run-clang-tidy.py` and then with sed
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticatee.cpp 
> 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
>   src/authentication/cram_md5/authenticator.cpp 
> 027eba4f433fff328d68c41005bc59c41c7ae668 
>   src/authentication/cram_md5/auxprop.cpp 
> d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 
> 0f0d9276337858984f0b19a82ffca74ee84dc650 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/example_module_impl.cpp 
> aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp 
> 7d64b6617564f43ef383ee60d92da92b2c958c47 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 
> 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 
> 76dd494fa4c32514ba14b1f4498b588ac9051b4d 
>   src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
>   src/examples/test_http_authenticator_module.cpp 
> 459b7046bd76d3043d2484a2dd30c10d7deaedd4 
>   src/examples/test_isolator_module.cpp 
> a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_qos_controller_module.cpp 
> f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
>   src/examples/test_resource_estimator_module.cpp 
> 229b2931e9129c194850f04051060d33bfa06570 
>   src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 
>   src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
>   src/java/jni/org_apache_mesos_state_Variable.cpp 
> 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
>   src/jvm/jvm.cpp 909d34a0112b219456dce76126029c603077e66d 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
>   src/linux/routing/diagnosis/diagnosis.cpp 
> 8b86a8864c08b078425dcc242d323763d6ec15dd 
>   src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
>   src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   

Review Request 44843: Replace NULL with nullptr.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44843/
---

Review request for mesos and Michael Park.


Bugs: MESOS-3243
https://issues.apache.org/jira/browse/MESOS-3243


Repository: mesos


Description
---

Replace NULLs with `run-clang-tidy.py` and then with sed


Diffs
-

  src/authentication/cram_md5/authenticatee.cpp 
7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8 
  src/authentication/cram_md5/authenticator.cpp 
027eba4f433fff328d68c41005bc59c41c7ae668 
  src/authentication/cram_md5/auxprop.cpp 
d82d2d2f7793859772d89cc91bee09240624c613 
  src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650 
  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/examples/example_module_impl.cpp aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
  src/examples/load_generator_framework.cpp 
7d64b6617564f43ef383ee60d92da92b2c958c47 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/examples/test_anonymous_module.cpp 
dd291cff3b5d47337e371cd2c1082fd6716af3fc 
  src/examples/test_authorizer_module.cpp 
19ec7cd114562f74c660b83b39235127d25001ee 
  src/examples/test_container_logger_module.cpp 
76dd494fa4c32514ba14b1f4498b588ac9051b4d 
  src/examples/test_hook_module.cpp abd132b3f39265683542a9d1533d2a31bd81769a 
  src/examples/test_http_authenticator_module.cpp 
459b7046bd76d3043d2484a2dd30c10d7deaedd4 
  src/examples/test_isolator_module.cpp 
a4a2103b1e449837b95948c8b5c25e05c5d13860 
  src/examples/test_qos_controller_module.cpp 
f382fc443fa0a4545ba78dc28016e4d0a0dd16b1 
  src/examples/test_resource_estimator_module.cpp 
229b2931e9129c194850f04051060d33bfa06570 
  src/exec/exec.cpp 741786132f3a8cc43f5b9ced262429038832a946 
  src/java/jni/construct.cpp 0bfe6291e94a69a787c965fa3a3a90d2ebae8d72 
  src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
  src/java/jni/org_apache_mesos_Log.cpp 
140b950136417eed7cba363a89537ed2f33832ff 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
9a92ade5d54bd814353acb40170d7aa4d8fe4a77 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
4fd43ca31c6917e81ea1b331b8507ca42a2249cf 
  src/java/jni/org_apache_mesos_state_Variable.cpp 
7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
23a89c3e5c5309a8a9b45c168fb61b12d89db1ec 
  src/jvm/jvm.cpp 909d34a0112b219456dce76126029c603077e66d 
  src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
  src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
  src/linux/routing/diagnosis/diagnosis.cpp 
8b86a8864c08b078425dcc242d323763d6ec15dd 
  src/linux/routing/route.cpp 4b33350dc3761e19121c29c0d090cfdae544e4ef 
  src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 
  src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
  src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
  src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
  src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
  src/logging/logging.cpp 8d9e4e9b200a0df1c67d4e7cd57107b7780f9812 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/http.cpp 1c2ca334567611578d9c6edb9ee7b0f43f0f1e18 
  src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa 
  src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e 
  src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca 
  src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 
  src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 
843771ae5b4f7e283d85c093e63c235dc753397d 
  src/python/executor/src/mesos/executor/module.cpp 
f8c63821db616475b95c3d1687893c251fa2daca 
  src/python/executor/src/mesos/executor/proxy_executor.cpp 
b9c8a2d131e5aadf6fa79af023bb34ae5a3cebba 
  src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 
78dc298ec19a61cd491b2b43b463db67528c5526 
  src/python/scheduler/src/mesos/scheduler/module.cpp 
62eaf3166c4ebef42665358e8da438b2e3afba20 
  src/python/scheduler/src/mesos/scheduler/proxy_scheduler.cpp 
3d8f3bfc9cbff761822580310432177d00450f51 
  src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
  src/scheduler/scheduler.cpp 35f479483740baed3f7bdbf45bf1d5bba3b9febc 
  src/slave/container_logger.cpp 85b8c1d3a42baba14741996d791926816b252742 
  src/slave/container_loggers/lib_logrotate.cpp