Re: Review Request 44848: Moved defaults in configuration.md to a new line for readability.

2016-03-15 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44848/#review123667
---



These docs were generated from the flag help strings, as printed by our flag 
renderer; at some point we might want to consider modifying the flag renderer 
to print the defaults on a new line as well.


docs/configuration.md (lines 98 - 99)


I viewed this with the Mesos website container 
(https://github.com/mesosphere/mesos-website-container) and the newlines have 
no effect, you need to explicitly include a line break with something like 
``.


- Greg Mann


On March 15, 2016, 1:22 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44848/
> ---
> 
> (Updated March 15, 2016, 1:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Greg Mann, and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the document is rendered in HTML, it is easier to spot defaults
> when they are on a new line. Also, the previous line should end with
> a period like in proper English text.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b 
> 
> Diff: https://reviews.apache.org/r/44848/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 44848: Moved defaults in configuration.md to a new line for readability.

2016-03-15 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44848/#review123654
---



Could you briefly check whether it renders as desired with our rakescript (and 
potentially also github as both sometimes differ)? THX

- Joerg Schad


On March 15, 2016, 1:22 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44848/
> ---
> 
> (Updated March 15, 2016, 1:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Greg Mann, and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the document is rendered in HTML, it is easier to spot defaults
> when they are on a new line. Also, the previous line should end with
> a period like in proper English text.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b 
> 
> Diff: https://reviews.apache.org/r/44848/diff/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 44848: Moved defaults in configuration.md to a new line for readability.

2016-03-15 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44848/
---

Review request for mesos, Bernd Mathiske, Greg Mann, and Joerg Schad.


Repository: mesos


Description
---

When the document is rendered in HTML, it is easier to spot defaults
when they are on a new line. Also, the previous line should end with
a period like in proper English text.


Diffs
-

  docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b 

Diff: https://reviews.apache.org/r/44848/diff/


Testing
---

None: not a functional change.


Thanks,

Alexander Rukletsov