Review Request 44912: Used the same fixture for all related tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/ --- Review request for mesos, Joris Van Remoortere and Yong Tang. Bugs: MESOS-4807 https://issues.apache.org/jira/browse/MESOS-4807 Repository: mesos Description --- The initial idea was to only use a fixture creating temporary working directories when really needed. It was felt that this hinders discoverability of related test. Diffs - 3rdparty/libprocess/src/tests/io_tests.cpp 87fd3fafc29c01362bae0b77a2a332ec89a8b442 Diff: https://reviews.apache.org/r/44912/diff/ Testing --- make check (OS X, clang-trunk, not optimized) Thanks, Benjamin Bannier
Re: Review Request 44912: Used the same fixture for all related tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123911 --- Ship it! Ship It! - Ben Mahler On March 16, 2016, 3:47 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44912/ > --- > > (Updated March 16, 2016, 3:47 p.m.) > > > Review request for mesos, Joris Van Remoortere and Yong Tang. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > The initial idea was to only use a fixture creating temporary working > directories when really needed. It was felt that this hinders > discoverability of related test. > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 87fd3fafc29c01362bae0b77a2a332ec89a8b442 > > Diff: https://reviews.apache.org/r/44912/diff/ > > > Testing > --- > > make check (OS X, clang-trunk, not optimized) > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 44912: Used the same fixture for all related tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123882 --- Ship it! Ship It! - Yong Tang On March 16, 2016, 3:47 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44912/ > --- > > (Updated March 16, 2016, 3:47 p.m.) > > > Review request for mesos, Joris Van Remoortere and Yong Tang. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > The initial idea was to only use a fixture creating temporary working > directories when really needed. It was felt that this hinders > discoverability of related test. > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 87fd3fafc29c01362bae0b77a2a332ec89a8b442 > > Diff: https://reviews.apache.org/r/44912/diff/ > > > Testing > --- > > make check (OS X, clang-trunk, not optimized) > > > Thanks, > > Benjamin Bannier > >
