Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-23 Thread Joerg Schad
> On March 21, 2016, 10:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter..

Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-23 Thread Adam B
> On March 21, 2016, 3:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter..

Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-23 Thread Adam B
> On March 21, 2016, 6:07 a.m., haosdent huang wrote: > > src/slave/http.cpp, line 212 > > > > > > Should we change `iff` to `if` here? https://en.wikipedia.org/w/index.php?title=Iff=no - Adam

Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-23 Thread Adam B
> On March 21, 2016, 3:28 a.m., Adam B wrote: > > src/slave/http.cpp, lines 351-354 > > > > > > Looks like `Master::Http::FLAGS_HELP()` is incorrectly using > > AUTHENTICATION() as its DESCRIPTION parameter..

Re: Review Request 45036: Added authentication information to agent endpoints.

2016-03-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/#review124539 --- src/slave/http.cpp (line 212)

Review Request 45036: Added authentication information to agent endpoints.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45036/ --- Review request for mesos, Adam B and greg-cooke greg-cooke. Repository: mesos