Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126510
---



Patch looks great!

Reviews applied: [44378, 45371]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 9:32 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake b89efd519eddfc96ce8fffb414d267a9770dda09 
>   LICENSE bbea085cfce1b9b3cbe002630955207f1c9ec60f 
>   src/python/native_common/ext_modules.py.in 
> 1c2fc49d0608570fa105628f28b9cc0b435e7e57 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Zhiwei Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated April 1, 2016, 5:32 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake b89efd519eddfc96ce8fffb414d267a9770dda09 
  LICENSE bbea085cfce1b9b3cbe002630955207f1c9ec60f 
  src/python/native_common/ext_modules.py.in 
1c2fc49d0608570fa105628f28b9cc0b435e7e57 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126454
---



Bad patch!

Reviews applied: [45371, 44378]

Failed command: ./support/apply-review.sh -n -r 44378

Error:
2016-03-31 21:29:45 URL:https://reviews.apache.org/r/44378/diff/raw/ 
[1351149/1351149] -> "44378.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/versions.am:6
error: 3rdparty/libprocess/3rdparty/versions.am: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12247/console

- Mesos ReviewBot


On March 31, 2016, 5:14 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126401
---



can you rebase this?

- Vinod Kone


On March 31, 2016, 5:14 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 31, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Zhiwei Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated March 31, 2016, 5:14 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Changes
---

set "depends on" field -- @vinodkone


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
  LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-31 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review126351
---


Ship it!




Ship It!

- Vinod Kone


On March 29, 2016, 10:28 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 29, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
>   LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-29 Thread Zhiwei Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated March 29, 2016, 6:28 p.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 
  LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-28 Thread Zhiwei Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

(Updated March 29, 2016, 10 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing (updated)
---

../configure --enable-libevent --enable-ssl

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen



Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-28 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/#review125621
---



Patch looks great!

Reviews applied: [45371]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 28, 2016, 2:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45371/
> ---
> 
> (Updated March 28, 2016, 2:18 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
> 
> Diff: https://reviews.apache.org/r/45371/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>



Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

2016-03-27 Thread Zhiwei Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen