Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review127714
---



How about `fetcher_cache_dir`, `appc_store_dir` and `docker_store_dir`?

- haosdent huang


On March 31, 2016, 9:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126474
---


Fix it, then Ship it!





docs/configuration.md (line 354)


Not yours but why isn't that flag in the common master/agent section above?



docs/configuration.md (line 361)


are *only* suitable for short-term?


- Joerg Schad


On March 31, 2016, 9:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated March 31, 2016, 9:22 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Changes
---

Addressed comment.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated March 31, 2016, 9 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs (updated)
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/#review126442
---




docs/configuration.md (line 361)


What's an "automatic garbage collection service"? Can we spell out what bad 
stuff might happen if `/tmp` is used for `work_dir`?



docs/configuration.md (line 1598)


Might be worth noting that the default value _is_ not consistent with this 
warning.


- Neil Conway


On March 31, 2016, 8:47 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45562/
> ---
> 
> (Updated March 31, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Bugs: MESOS-5064
> https://issues.apache.org/jira/browse/MESOS-5064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some users have encountered difficulty when running the Mesos agent with the 
> `work_dir` located in a subdirectory of `/tmp`. This patch adds language to 
> the `work_dir` help strings and configuration docs advising users to avoid 
> the use of this location in production.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
>   src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 
> 
> Diff: https://reviews.apache.org/r/45562/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 45562: Edited `--work_dir` help strings and docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

Review request for mesos, Jie Yu and Neil Conway.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent with the 
`work_dir` located in a subdirectory of `/tmp`. This patch adds language to the 
`work_dir` help strings and configuration docs advising users to avoid the use 
of this location in production.


Diffs
-

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 
  src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann