Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
> On June 11, 2016, 2:27 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 37-38 > > > > > > So even after we introduce the unified cgroups isolator, we still need > >

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated June 19, 2016, 10:32 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review137118 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-10 Thread Qian Zhang
> On June 6, 2016, 9:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 150-156 > > > > > > I see in this hashmap, the keys and values are exactly same, e.g., > >

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-07 Thread haosdent huang
> On June 6, 2016, 1:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 150-156 > > > > > > I see in this hashmap, the keys and values are exactly same, e.g., > >

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review136248 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-05 Thread Qian Zhang
> On June 5, 2016, 12:43 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 101 > > > > > > Would reach here if don't meet `Error`. Sorry, my bad, you are right :-)

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-02 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review135937 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:28 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:22 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 16, 2016, 10:19 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 13, 2016, 6:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- (Updated April 1, 2016, 10:45 a.m.) Review request for mesos and Jie Yu.

Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-03-31 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5047